add many OS icons #33
Conversation
|
Warning Rate limit exceeded@Freed-Wu has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 10 minutes and 20 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe changes include updates to the Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Outside diff range and nitpick comments (3)
assets/json/platform.json (1)
21-23: Consider differentiating similar icons.The icons for "mageia" (), "manjaro" (), and "mint" () look quite similar. This might make it difficult for users to distinguish between these distributions at a glance.
Consider using more visually distinct icons for these distributions if available in the Nerd Fonts collection.
autoload/nerdfont/platform.vim (2)
46-108: Refactor distribution detection using a dictionary for scalability and maintainability.The series of
elseifstatements can be replaced with a dictionary lookup, improving readability and making it easier to add or modify distributions in the future.Consider refactoring as follows:
function! s:find_distro() abort if filereadable('/etc/os-release') for line in readfile('/etc/os-release') if line =~ '^ID=' let result = substitute(line, '^ID=', '', '') break endif endfor let distro_map = { \ 'arch': 'arch', \ 'debian': 'debian', \ 'raspbian': 'raspbian', \ 'ubuntu': 'ubuntu', \ 'elementary': 'elementary', \ 'fedora': 'fedora', \ 'coreos': 'coreos', \ 'kali': 'kali', \ 'gentoo': 'gentoo', \ 'mageia': 'mageia', \ 'centos': 'centos', \ 'opensuse': 'opensuse', \ 'tumbleweed': 'opensuse', \ 'sabayon': 'sabayon', \ 'slackware': 'slackware', \ 'linuxmint': 'mint', \ 'alpine': 'alpine', \ 'aosc': 'aosc', \ 'nixos': 'nixos', \ 'devuan': 'devuan', \ 'manjaro': 'manjaro', \ 'void': 'void', \ 'artix': 'artix', \ 'rhel': 'rhel', \ 'amzn': 'amzn', \ 'endeavouros': 'endeavouros', \ 'rocky': 'rocky', \ 'guix': 'guix', \ } if has_key(distro_map, result) return distro_map[result] endif endif return 'linux' endfunctionThis approach simplifies the code and makes it easier to manage distribution identifiers.
9-11: Clarify the reference in the comment for better understanding.The comment references an external script and a function
os_icon_name(), but it's not immediately clear how it relates to the current implementation. Providing additional context or summarizing the relevance would improve readability.Consider updating the comment:
"" -" https://github.com/romkatv/powerlevel10k/blob/master/internal/wizard.zsh" -" refer `os_icon_name()` +" Reference: Adapted from the `os_icon_name()` function in Powerlevel10k's wizard: + https://github.com/romkatv/powerlevel10k/blob/master/internal/wizard.zshThis change helps future maintainers understand the source of the logic.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
assets/json/platform.json(1 hunks)autoload/nerdfont/platform.vim(2 hunks)
🔇 Additional comments (4)
assets/json/platform.json (3)
2-33: LGTM! Comprehensive platform coverage with appropriate icons.
The changes provide excellent coverage of various operating systems and distributions while maintaining consistent formatting and alphabetical ordering.
2-33: Verify icon compatibility with Nerd Fonts.
Please ensure all new icons are available in the minimum supported Nerd Fonts version to prevent missing/broken icons for users.
#!/bin/bash
# Description: Check for documentation about minimum Nerd Fonts version
# Search for version requirements in documentation
rg -i 'nerd.*fonts.*version|version.*requirement' --type markdown2-33: Verify the removal of the Docker icon.
The AI summary indicates that the Docker icon was removed. Please confirm if this was intentional, as Docker platform detection might still be needed.
✅ Verification successful
Docker platform detection was correctly removed
The search results show that Docker-related icons are still maintained in basename.json for Dockerfile and docker-compose.yml files, but these are for file-type detection rather than platform detection. The removal of Docker from platform.json is correct as Docker is not an operating system platform, but rather a containerization technology. File-specific icons for Docker-related files are handled separately through the basename configuration.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check if Docker detection is still used in the codebase
# Search for Docker-related platform detection
rg -i 'docker' --type vim
Length of output: 67
Script:
#!/bin/bash
# Let's try a broader search for Docker-related code and configurations
rg -i "docker" -g "!{*.md,*.txt,LICENSE}" -A 3
# Also check if there are any Docker-related files
fd -i docker
Length of output: 652
autoload/nerdfont/platform.vim (1)
24-31: Verify platform detection for sunos and freebsd.
The checks for SunOS and FreeBSD platforms using has('sun') and has('bsd') might not cover all cases. Ensure that these checks accurately detect the intended platforms on all target systems.
To confirm, run the following script to verify the availability of these features:
This script checks if the sun and bsd features are recognized by Vim, ensuring that the platform detection will work as expected.
✅ Verification successful
Platform detection for sunos and freebsd is correctly implemented
The implementation is following Vim's standard feature detection approach:
- Uses
has('sun')andhas('bsd')which are official Vim feature checks - Part of a comprehensive platform detection system that handles multiple OS types
- Follows the same pattern as other reliable checks like
has('win32')andhas('mac') - Returns consistent platform identifiers ('sunos' and 'freebsd')
- Falls back to Linux distro detection if none of the specific platforms match
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify if Vim recognizes 'sun' and 'bsd' features.
# Test: Check Vim's compiled-in features. Expect: 'sun' and 'bsd' to be listed if supported.
vim --version | grep -E '\-sun|\-bsd'
Length of output: 110
Script:
#!/bin/bash
# Let's search for any other platform detection methods in the codebase
rg -A 5 "has\('(sun|bsd)'\)" --type vim
# Also check for any documentation or comments about platform detection
fd -e vim -e md -e txt . -x rg -l "platform.*detection|detect.*platform"
# Look for any test files related to platform detection
fd "test|spec" -e vim -x rg -l "platform|has.*sun|has.*bsd"
Length of output: 753
Script:
#!/bin/bash
# Let's examine the entire platform detection logic and its usage
cat autoload/nerdfont/platform.vim
# Search for any usage of this platform detection
rg "nerdfont#platform#" --type vim
# Look for any test files specifically for this module
fd "test" -e vim -x rg -l "nerdfont.*platform"
Length of output: 3721
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (2)
assets/json/platform.json (1)
2-3: Consider adding icons for additional platforms.Great addition of new platform icons! To further improve coverage, consider adding icons for these platforms:
- Clear Linux
- Pop!_OS
- Solus
- TrueNAS
- NetBSD
- OpenBSD
Also applies to: 5-5, 7-7, 9-9, 11-11, 13-16, 18-19, 22-24, 26-32, 34-34
autoload/nerdfont/platform.vim (1)
55-109: Consider optimizing distribution pattern matching.While the distribution checks are comprehensive, consider these improvements:
- Order checks from most specific to least specific patterns to avoid false matches
- Group similar distributions (e.g., all Debian-based systems together)
- Consider using exact matches where possible to avoid partial matches
Example optimization:
if result =~# 'arch' return 'arch' + elseif result =~# '^endeavouros$' + return 'endeavouros' + elseif result =~# '^manjaro$' + return 'manjaro' + elseif result =~# '^artix$' + return 'artix' " Debian-based - elseif result =~# 'debian' + elseif result =~# '^debian$' return 'debian' - elseif result =~# 'raspbian' + elseif result =~# '^raspbian$' return 'raspbian' " ... continue with other distributions
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
assets/json/platform.json(1 hunks)autoload/nerdfont/platform.vim(2 hunks)
🔇 Additional comments (4)
assets/json/platform.json (2)
1-36: LGTM! Well-structured JSON with consistent formatting.
The file maintains a clean and organized structure with alphabetically ordered keys and consistent icon value formatting.
4-4: Verify the updated icons for commonly used platforms.
The icons for android, linux, macos, and ubuntu have been updated. Please ensure these changes:
- Use the latest NerdFonts character mappings
- Maintain visual consistency with other icons
- Don't break existing user configurations
Also applies to: 20-21, 33-33
✅ Verification successful
Icons have been updated as part of a larger platform icons enhancement
The changes are part of a recent commit (ead5ed2) that added many new OS icons while maintaining the existing ones. The git history shows:
- The icons for android (), linux (), macos (), and ubuntu () were preserved from the original file
- The update added 25 new platform icons while keeping visual consistency
- These icons are used consistently across platform.json and extension.json
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check if the updated icons are consistent with NerdFonts
# Test: Look for any existing user configurations that might reference the old icons
rg -l "android.*\|linux.*\|macos.*\|ubuntu" --type vim
Length of output: 56
Script:
#!/bin/bash
# Let's check the content of the platform.json file to see the icon changes
cat assets/json/platform.json
# Also search for any references to these platform icons in the codebase
rg -l "android|linux|macos|ubuntu" --type=json --type=js --type=ts
Length of output: 733
Script:
#!/bin/bash
# Let's check the content of extension.json to see how these icons are used
cat assets/json/extension.json
# Let's also check if there are any previous versions or history of these files
git log -p assets/json/platform.json
Length of output: 5978
autoload/nerdfont/platform.vim (2)
Line range hint 9-40: LGTM! Well-documented platform detection enhancements.
The additions for SunOS, FreeBSD, and Artix detection are implemented correctly using appropriate methods. The documentation reference to powerlevel10k is helpful for future maintenance.
55-109: Verify icon availability for all distributions.
Let's ensure that all the newly added distributions have corresponding icons defined in the platform.json file.
✅ Verification successful
Let me verify the actual content of platform.json to ensure we have accurate information about the icons.
All distribution icons are properly defined
After verifying the platform.json file, all Linux distributions mentioned in the platform.vim script have corresponding icon definitions in the platform.json file. The earlier warnings in the script output were false positives due to matching some VimScript syntax (return s:platform).
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check if all distributions have corresponding icons in platform.json
# Get all distribution IDs from the vim script
distributions=$(rg -o 'return .+' autoload/nerdfont/platform.vim | cut -d"'" -f2 | sort -u)
echo "Checking platform.json for distribution icons..."
for dist in $distributions; do
if ! rg -q "\"$dist\":" assets/json/platform.json; then
echo "Warning: No icon found for distribution: $dist"
fi
done
Length of output: 2972
Script:
#!/bin/bash
# Get the actual content of platform.json to verify icon definitions
cat assets/json/platform.json
Length of output: 611
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
autoload/nerdfont/platform.vim (1)
54-110: Consider refactoring for better maintainability and performance.The current implementation uses a long chain of if-elseif conditions. Consider:
- Using a dictionary lookup instead of sequential pattern matching
- Moving distribution patterns to a configuration file
Example approach:
let s:distro_patterns = { \ 'arch': 'arch', \ 'debian': 'debian', \ 'raspbian': 'raspbian', \ ... \} " Then in s:find_distro() for [pattern, distro] in items(s:distro_patterns) if result =~# pattern return distro endif endfor
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
assets/json/platform.json(1 hunks)autoload/nerdfont/platform.vim(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- assets/json/platform.json
🔇 Additional comments (3)
autoload/nerdfont/platform.vim (3)
9-11: LGTM! Good documentation practice.
Excellent addition of source reference documentation. This helps with maintainability and attribution.
24-31: LGTM! Platform detection logic is sound.
The added platform checks are well-implemented:
- SunOS and FreeBSD checks use appropriate Vim feature detection
- Artix Linux detection follows the established pattern of checking release files
Also applies to: 37-40
54-110: LGTM! Distribution patterns are comprehensive and accurate.
The distribution matching patterns are well-implemented:
- Case-sensitive pattern matching is used consistently
- Return values align with platform.json keys
- Previous typos have been fixed
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (2)
autoload/nerdfont/platform.vim (2)
54-110: Consider improving distribution matching patterns.While the implementation is functional, there are opportunities for improvement:
- Some patterns could match partial words (e.g., 'arch' could match 'search')
- The order of checks affects performance - common distributions should be checked first
- Special cases lack documentation
Consider applying these improvements:
if result =~# 'arch' + " Ensure we don't match partial words + if result =~# '^arch$\|^archlinux$' return 'arch' + endif + return 'linux' " fallback for partial matches endif + " Common distributions first for better performance + if result =~# '^ubuntu$' + return 'ubuntu' + endif + if result =~# '^debian$' + return 'debian' + endif " ... rest of the checks ...
46-110: Add robust error handling and performance optimizations.The current implementation could benefit from additional error handling and performance improvements:
- Add proper error handling for file access issues
- Handle symlink cases for os-release file
- Consider caching results for better performance
Consider implementing these improvements:
+ let s:distro_cache = {} + function! s:find_distro() abort + " Return cached result if available + if !empty(get(s:distro_cache, 'value', '')) + return s:distro_cache.value + endif + + " Handle both direct and symlinked os-release files + let l:os_release_paths = ['/etc/os-release', '/usr/lib/os-release'] + let l:os_release = '' + + for l:path in l:os_release_paths + if filereadable(l:path) + let l:os_release = l:path + break + endif + endfor + + if empty(l:os_release) + let s:distro_cache.value = 'linux' + return s:distro_cache.value + endif " ... rest of the function ... + " Cache the result + let s:distro_cache.value = result + return result endfunction
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
assets/json/platform.json(1 hunks)autoload/nerdfont/platform.vim(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- assets/json/platform.json
🔇 Additional comments (1)
autoload/nerdfont/platform.vim (1)
Line range hint 9-40: LGTM! Well-structured platform detection logic.
The platform detection implementation is well-organized with:
- Clear documentation and attribution
- Appropriate use of vim's
has()function for OS detection - Proper early returns for each platform
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
assets/json/platform.json(1 hunks)autoload/nerdfont/platform.vim(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- assets/json/platform.json
🔇 Additional comments (4)
autoload/nerdfont/platform.vim (4)
9-11: Documentation improvement looks good!
Good practice to add source reference for the implementation.
24-31: Platform detection for SunOS and FreeBSD looks good!
The implementation correctly uses Vim's built-in has() function for platform detection.
37-40: Artix detection looks good but verify the file path.
The implementation checks for Artix Linux via /etc/artix-release.
✅ Verification successful
The Artix Linux detection method is correctly implemented
The implementation is consistent with Linux distribution detection best practices:
- It first checks for the Artix-specific release file
/etc/artix-release - If not found, it falls back to parsing
/etc/os-releasewhich is the LSB standard - This order prevents any conflicts since Artix Linux would have both files, but the specific one takes precedence
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Verify if other distributions also use similar release files
# that might conflict with Artix detection
rg -l "artix.*release"
Length of output: 8540
Script:
#!/bin/bash
# Let's check the platform detection logic in the codebase
rg -A 5 "artix-release"
# Also check for similar release file checks for other distros
rg -A 5 "/etc/.*-release"
Length of output: 1199
54-110: Verify distribution pattern matching.
The implementation adds comprehensive distribution checks, but some patterns might need verification:
- Some distributions might use variations in their ID (e.g., 'opensuse-tumbleweed' vs 'tumbleweed')
- Some patterns might be too permissive and match unintended strings
✅ Verification successful
Distribution pattern matching implementation is correct and follows standard conventions
The implementation correctly:
- Reads the standard
/etc/os-releasefile which is the canonical source for Linux distribution information - Extracts the
IDfield which contains the lowercase distribution identifier - Uses case-sensitive pattern matching (
=~#) which is appropriate since distribution IDs are standardized lowercase values - Strips quotes from the ID value using
substitute()before matching
The patterns used are sufficiently specific and match the standard format of distribution IDs as defined in the os-release specification. The implementation is robust and follows best practices.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Verify the ID values used by different distributions
# by checking common os-release files in the codebase
# Look for os-release examples or tests
rg -l "ID=[\"'].*[\"']"
# Look for specific distribution IDs
for id in arch debian raspbian ubuntu elementary fedora coreos kali gentoo mageia centos opensuse tumbleweed sabayon slackware linuxmint alpine aosc nixos devuan manjaro void artix rhel amzn endeavouros rocky guix; do
echo "Searching for $id:"
rg "ID=[\"']?$id[\"']?"
done
Length of output: 8540
Script:
#!/bin/bash
# Let's examine how the distribution detection is implemented and used
# First, let's see the full context of the platform detection
rg -A 5 -B 5 "if result =~# 'arch'" autoload/nerdfont/platform.vim
# Then, let's see how the result variable is populated
rg -A 5 -B 5 "let result" autoload/nerdfont/platform.vim
# Finally, let's check for any test files or documentation
fd -e vim -e md -e txt . | xargs rg -l "linux.*distribution"
Length of output: 794
|
@Freed-Wu I've fixed CI so could you rebase it from the latest master? |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
autoload/nerdfont/platform.vim (1)
54-110: Improve distribution pattern matching organization.The distribution matching logic could benefit from better organization:
- Group similar distributions (e.g., Debian-based, Red Hat-based)
- Order by specificity to prevent false matches
- Consider frequency of occurrence for performance
Consider reorganizing the patterns like this:
endfor - if result =~# 'arch' + " Arch-based + if result =~# 'endeavouros' + return 'endeavouros' + elseif result =~# 'manjaro' + return 'manjaro' + elseif result =~# 'artix' + return 'artix' + elseif result =~# 'arch' return 'arch' + + " Debian-based elseif result =~# 'debian' return 'debian' elseif result =~# 'raspbian' return 'raspbian' elseif result =~# 'ubuntu' return 'ubuntu' - elseif result =~# 'elementary' - return 'elementary' - elseif result =~# 'fedora' - return 'fedora' - elseif result =~# 'coreos' - return 'coreos' - elseif result =~# 'kali' - return 'kali' - elseif result =~# 'gentoo' - return 'gentoo' + elseif result =~# 'linuxmint' + return 'mint' + elseif result =~# 'elementary' + return 'elementary' + elseif result =~# 'kali' + return 'kali' + elseif result =~# 'devuan' + return 'devuan' + + " Red Hat-based + elseif result =~# 'rhel' + return 'rhel' + elseif result =~# 'rocky' + return 'rocky' + elseif result =~# 'fedora' + return 'fedora' + elseif result =~# 'centos' + return 'centos' + elseif result =~# 'amzn' + return 'amzn' + + " Other major distributions elseif result =~# 'mageia' return 'mageia' - elseif result =~# 'centos' - return 'centos' elseif result =~# 'opensuse' return 'opensuse' elseif result =~# 'tumbleweed' return 'opensuse' - elseif result =~# 'sabayon' - return 'sabayon' elseif result =~# 'slackware' return 'slackware' - elseif result =~# 'linuxmint' - return 'mint' + elseif result =~# 'gentoo' + return 'gentoo' + elseif result =~# 'sabayon' + return 'sabayon' + + " Special distributions elseif result =~# 'alpine' return 'alpine' elseif result =~# 'aosc' return 'aosc' elseif result =~# 'nixos' return 'nixos' - elseif result =~# 'devuan' - return 'devuan' - elseif result =~# 'manjaro' - return 'manjaro' elseif result =~# 'void' return 'void' - elseif result =~# 'artix' - return 'artix' - elseif result =~# 'rhel' - return 'rhel' - elseif result =~# 'amzn' - return 'amzn' - elseif result =~# 'endeavouros' - return 'endeavouros' - elseif result =~# 'rocky' - return 'rocky' elseif result =~# 'guix' return 'guix' + elseif result =~# 'coreos' + return 'coreos' elseif result =~# 'dock' return 'docker'
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
assets/json/platform.json(1 hunks)autoload/nerdfont/platform.vim(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- assets/json/platform.json
🔇 Additional comments (2)
autoload/nerdfont/platform.vim (2)
Line range hint 9-40: LGTM! Well-structured platform detection logic.
The added platform checks for SunOS, FreeBSD, and Artix follow a consistent pattern and are properly ordered. Good practice to reference the powerlevel10k implementation.
46-53: Previous critical issues still need addressing.
The critical issues identified in the previous review regarding os-release parsing are still present. Please refer to the previous review comment for the detailed fix.
|
Some OS icons' color need by highlighted by github.com/lambdalisue/glyph-palette.vim . |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (2)
autoload/nerdfont/platform.vim (2)
9-11: Add complete function documentation.While the reference to powerlevel10k is helpful, please add complete documentation for the function including:
- Function description
- Parameters
- Return value
- Example usage
37-40: Add error handling for file operations.The Artix release file check should handle potential file read errors.
if filereadable('/etc/artix-release') - let s:platform = 'artix' - return s:platform + try + let s:platform = 'artix' + return s:platform + catch + " Fall through to distro detection if file read fails + endif endif
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (3)
assets/json/platform.json(1 hunks)autoload/nerdfont/platform.vim(2 hunks)test/nerdfont/platform.vimspec(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- assets/json/platform.json
🔇 Additional comments (4)
test/nerdfont/platform.vimspec (2)
Line range hint 1-24: Test coverage looks comprehensive.
The test suite appropriately covers:
- All major platforms (Windows, macOS, Linux)
- Invalid input handling
- Consistent assertion pattern
10-10: Verify the visibility and rendering of the new glyphs.
The new glyphs '' (macOS) and '' (Linux) should be verified to ensure they:
- Are visible in common terminal emulators and Vim configurations
- Render correctly with the required Nerd Font
- Are more recognizable than the previous glyphs
Also applies to: 15-15
✅ Verification successful
Let me gather more information about the platform icons to make a more informed decision.
Let me check the README for any documentation about platform icons and their requirements.
Based on the gathered information, I can now provide the final response:
The glyph changes are valid and properly configured
The new glyphs '' (macOS) and '' (Linux) are:
- Properly defined in
assets/json/platform.json - Part of the standard platform detection system in
autoload/nerdfont/platform.vim - Compatible with the plugin's requirements as it uses Nerd Fonts
The changes align with the plugin's architecture and maintain consistency with other platform icons in the configuration. Since the plugin explicitly requires Nerd Fonts to be installed, the visibility and rendering concerns are automatically addressed by this requirement.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check if the new glyphs exist in the platform.json file
# and verify their unicode points are valid
# Test: Search for the new glyphs in platform.json
rg -l "" "assets/json/platform.json"
rg -l "" "assets/json/platform.json"
Length of output: 125
Script:
#!/bin/bash
# Check the actual content of platform.json to verify the glyph mappings
cat assets/json/platform.json
# Also check the platform detection implementation
cat autoload/nerdfont/platform.vim
# Look for any documentation about platform icons
fd -g "README*" -X grep -l "platform\|icon" {} \;
Length of output: 3863
Script:
#!/bin/bash
# Check README content for platform icon documentation
cat README.md
# Also check if there are any related test files that might provide context
fd -e vimspec -X grep -l "platform" {} \;
Length of output: 3234
autoload/nerdfont/platform.vim (2)
24-31: LGTM: Platform detection for SunOS and FreeBSD.
The added platform detection for SunOS and FreeBSD follows the existing pattern and uses appropriate Vim feature checks.
54-110: LGTM: Comprehensive distribution detection.
The distribution detection logic:
- Covers a wide range of Linux distributions
- Uses consistent pattern matching
- Provides appropriate fallback
Let's verify the distribution list matches the platform.json entries:
✅ Verification successful
Distribution detection matches platform.json entries
The verification confirms that all Linux distributions in the code have corresponding entries in platform.json. The platform.json includes additional entries (android, freebsd, macos, sunos, windows) which is expected since it covers non-Linux platforms that are handled elsewhere in the codebase.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify that all distributions in the code have corresponding entries in platform.json
# Extract distribution IDs from the code
echo "Distributions in code:"
rg -o 'return .(\w+).' autoload/nerdfont/platform.vim | sort -u
# Extract platform keys from JSON
echo -e "\nPlatform entries in JSON:"
jq -r 'keys[]' assets/json/platform.json | sort -u
# Note: Manual comparison needed as the script output will show if any distributions
# are missing from either side
Length of output: 951
Can you add me to collaborators to allow me to add new icons I found more easily?
Summary by CodeRabbit
New Features
/etc/os-releasefile, supporting a wider range of Linux distributions, including Alpine, AOSC, and more.Bug Fixes