Fix code remarks

lambdaworks · Nov 17, 2023 · 5914223 · 5914223
1 parent 8583e50
commit 5914223
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/modules/integration/src/test/scala/zio/elasticsearch/HttpExecutorSpec.scala b/modules/integration/src/test/scala/zio/elasticsearch/HttpExecutorSpec.scala
@@ -190,12 +190,10 @@ object HttpExecutorSpec extends IntegrationSpec {
                            .refreshTrue
                        )
                   query = term(field = TestDocument.stringField, value = secondDocumentUpdated.stringField.toLowerCase)
-
                   aggregation =
                     filterAggregation(name = "aggregation", query = query).withSubAgg(
                       maxAggregation("subAggregation", TestDocument.intField)
                     )
-
                   aggsRes <-
                     Executor
                       .execute(ElasticRequest.aggregate(selectors = firstSearchIndex, aggregation = aggregation))

diff --git a/modules/library/src/main/scala/zio/elasticsearch/executor/response/AggregationResponse.scala b/modules/library/src/main/scala/zio/elasticsearch/executor/response/AggregationResponse.scala
@@ -307,7 +307,6 @@ private[elasticsearch] final case class SumAggregationResponse(value: Double) ex
 
 private[elasticsearch] object SumAggregationResponse {
   implicit val decoder: JsonDecoder[SumAggregationResponse] = DeriveJsonDecoder.gen[SumAggregationResponse]
-
 }
 
 private[elasticsearch] final case class TermsAggregationResponse(

diff --git a/modules/library/src/test/scala/zio/elasticsearch/ElasticAggregationSpec.scala b/modules/library/src/test/scala/zio/elasticsearch/ElasticAggregationSpec.scala
@@ -158,7 +158,7 @@ object ElasticAggregationSpec extends ZIOSpecDefault {
             filterAggregation("aggregation", query).withSubAgg(minAggregation("subAggregation", TestDocument.intField))
           val aggregationWithMultipleSubAggregations = filterAggregation("aggregation", query)
             .withSubAgg(maxAggregation("maxSubAggregation", TestDocument.intField))
-            .withSubAgg(minAggregation("minSubAggregation", TestDocument.intField))
+            .withSubAgg(minAggregation("minSubAggregation", TestDocument.doubleField))
 
           assert(aggregation)(
             equalTo(
@@ -184,7 +184,7 @@ object ElasticAggregationSpec extends ZIOSpecDefault {
                 name = "aggregation",
                 query = query,
                 subAggregations = Chunk(
-                  minAggregation("minSubAggregation", TestDocument.intField),
+                  minAggregation("minSubAggregation", TestDocument.doubleField),
                   maxAggregation("maxSubAggregation", TestDocument.intField)
                 )
               )
@@ -872,7 +872,7 @@ object ElasticAggregationSpec extends ZIOSpecDefault {
             filterAggregation("aggregation", query).withSubAgg(minAggregation("subAggregation", TestDocument.intField))
           val aggregationWithMultipleSubAggregations = filterAggregation("aggregation", query)
             .withSubAgg(maxAggregation("maxSubAggregation", TestDocument.intField))
-            .withSubAgg(minAggregation("minSubAggregation", TestDocument.intField))
+            .withSubAgg(minAggregation("minSubAggregation", TestDocument.doubleField))
 
           val expected =
             """
@@ -930,7 +930,7 @@ object ElasticAggregationSpec extends ZIOSpecDefault {
               |       },
               |       "minSubAggregation": {
               |         "min": {
-              |           "field": "intField"
+              |           "field": "doubleField"
               |         }
               |       }
               |     }