-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(dsl): Support 'matchPhrase' query #172
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e95a69d
Support matchPhrase query
drmarjanovic 64d324b
Fix warning for the example app
drmarjanovic 993576e
Restrict matchPhrase query to use String only
drmarjanovic f88f6f0
Add match phrase query website template
drmarjanovic a7b6fbd
Provide 'boost' query to match and match phrase queries
drmarjanovic 42dfb3c
Improve docs
drmarjanovic a9cfff7
Provide Query DSL tests
drmarjanovic 750a678
Provide integration test
drmarjanovic 99a3f20
Fix docs
drmarjanovic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
id: elastic_query_match_phrase | ||
title: "Match Phrase Query" | ||
--- | ||
|
||
TBD |
29 changes: 29 additions & 0 deletions
29
modules/example/src/main/scala/example/api/ErrorResponse.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
/* | ||
* Copyright 2022 LambdaWorks | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package example.api | ||
|
||
import zio.Chunk | ||
import zio.json.{DeriveJsonEncoder, JsonEncoder} | ||
|
||
final case class ErrorResponse(errors: ErrorResponseData) | ||
|
||
object ErrorResponse { | ||
implicit val encoder: JsonEncoder[ErrorResponse] = DeriveJsonEncoder.gen[ErrorResponse] | ||
|
||
def fromReasons(reasons: String*): ErrorResponse = | ||
new ErrorResponse(ErrorResponseData(Chunk.fromIterable(reasons))) | ||
} |
26 changes: 26 additions & 0 deletions
26
modules/example/src/main/scala/example/api/ErrorResponseData.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
/* | ||
* Copyright 2022 LambdaWorks | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package example.api | ||
|
||
import zio.Chunk | ||
import zio.json.{DeriveJsonEncoder, JsonEncoder} | ||
|
||
final case class ErrorResponseData(body: Chunk[String]) | ||
|
||
object ErrorResponseData { | ||
implicit val encoder: JsonEncoder[ErrorResponseData] = DeriveJsonEncoder.gen[ErrorResponseData] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -592,6 +592,30 @@ object HttpExecutorSpec extends IntegrationSpec { | |
Executor.execute(ElasticRequest.createIndex(firstSearchIndex)), | ||
Executor.execute(ElasticRequest.deleteIndex(firstSearchIndex)).orDie | ||
), | ||
test("search for a document using a match phrase query") { | ||
checkOnce(genDocumentId, genTestDocument, genDocumentId, genTestDocument) { | ||
(firstDocumentId, firstDocument, secondDocumentId, secondDocument) => | ||
for { | ||
_ <- Executor.execute(ElasticRequest.deleteByQuery(firstSearchIndex, matchAll)) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why do we need to delete everything if we're recreating the index between each test? |
||
document = firstDocument.copy(stringField = s"this is ${firstDocument.stringField} test") | ||
_ <- | ||
Executor.execute(ElasticRequest.upsert[TestDocument](firstSearchIndex, firstDocumentId, document)) | ||
_ <- Executor.execute( | ||
ElasticRequest | ||
.upsert[TestDocument](firstSearchIndex, secondDocumentId, secondDocument) | ||
.refreshTrue | ||
) | ||
query = matchPhrase( | ||
field = TestDocument.stringField, | ||
value = firstDocument.stringField | ||
) | ||
res <- Executor.execute(ElasticRequest.search(firstSearchIndex, query)).documentAs[TestDocument] | ||
} yield assert(res)(Assertion.contains(document)) | ||
} | ||
} @@ around( | ||
Executor.execute(ElasticRequest.createIndex(firstSearchIndex)), | ||
Executor.execute(ElasticRequest.deleteIndex(firstSearchIndex)).orDie | ||
), | ||
test("search for a document using nested query") { | ||
checkOnce(genDocumentId, genTestDocument, genDocumentId, genTestDocument) { | ||
(firstDocumentId, firstDocument, secondDocumentId, secondDocument) => | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this result in a structure like:
?
Can we simplify that and also avoid naming a class with
Data
?