Support minimumShouldMatch on BoolQuery
#184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markaya
reviewed
Apr 25, 2023
Comment on lines
+68
to
+70
| def minimumShouldMatch(value: Int): BoolQuery[S] = | ||
| self.copy(minimumShouldMatch = Some(value)) | ||
|
|
There was a problem hiding this comment.
Sorted alphabetically.
| @@ -120,6 +120,21 @@ package object query { | |||
| def innerHits(innerHits: InnerHits): Q | |||
| } | |||
|
|
|||
| private[elasticsearch] trait HasMinimumShouldMatch[Q <: HasBoost[Q]] { | |||
There was a problem hiding this comment.
Suggested change
| private[elasticsearch] trait HasMinimumShouldMatch[Q <: HasBoost[Q]] { | |
| private[elasticsearch] trait HasMinimumShouldMatch[Q <: HasMinimumShouldMatch[Q]] { |
dbulaja98
reviewed
Apr 25, 2023
| * @param value | ||
| * a number to set `minimumShouldMatch` parameter to | ||
| * @return | ||
| * a new instance of the [[ElasticQuery]] with the `minimumShouldMatch` value set. |
There was a problem hiding this comment.
If this applies only on BoolQuery, maybe write it here instead of ElasticQuery.
There was a problem hiding this comment.
Not sure if there are any other places to be supported.
There was a problem hiding this comment.
At least match bool prefix query supports this. So, let's have it in a separate trait.
markaya
approved these changes
Apr 25, 2023
arnoldlacko
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
minimumShouldMatchsupport forBoolQuery.paramsToJsonandtoJsonmethods as package private.minimumShouldMatchis successfully set.