(dsl): Add has parent query #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbulaja98
requested changes
Apr 25, 2023
Comment on lines
125
to
129
| def withScore(value: Boolean): HasParentQuery[S] | ||
|
|
||
| def withScoreTrue: HasParentQuery[S] = withScore(true) | ||
|
|
||
| def withScoreFalse: HasParentQuery[S] = withScore(false) |
There was a problem hiding this comment.
Maybe to extract this like rest of option params? Maybe it will occur in some other query?
There was a problem hiding this comment.
I would leave it for now as I haven't found any that have this field.
| score: Option[Boolean] = None | ||
| ) extends HasParentQuery[S] { self => | ||
|
|
||
| override def ignoreUnmapped(value: Boolean): HasParentQuery[S] = |
| override def ignoreUnmapped(value: Boolean): HasParentQuery[S] = | ||
| self.copy(ignoreUnmapped = Some(value)) | ||
|
|
||
| override def paramsToJson(fieldPath: Option[String]): Json = |
drmarjanovic
requested changes
Apr 26, 2023
| * Constructs an instance of [[zio.elasticsearch.query.HasParent]] using the specified parameters. | ||
| * | ||
| * @param parentType | ||
| * a name of the parent relationship mapped for the join field. |
There was a problem hiding this comment.
Suggested change
| * a name of the parent relationship mapped for the join field. | |
| * a name of the parent relationship mapped for the join field |
| * @param parentType | ||
| * a name of the parent relationship mapped for the join field. | ||
| * @param query | ||
| * query you wish to run on parent documents of the parent_type field. |
There was a problem hiding this comment.
Suggested change
| * query you wish to run on parent documents of the parent_type field. | |
| * query you wish to run on parent documents of the `parent_type` field |
| * Constructs an instance of [[zio.elasticsearch.query.HasParent]] using the specified parameters. | ||
| * | ||
| * @param parentType | ||
| * a name of the parent relationship mapped for the join field. |
There was a problem hiding this comment.
Suggested change
| * a name of the parent relationship mapped for the join field. | |
| * a name of the parent relationship mapped for the join field |
| * @param parentType | ||
| * a name of the parent relationship mapped for the join field. | ||
| * @param query | ||
| * query you wish to run on parent documents of the parent_type field. |
There was a problem hiding this comment.
Suggested change
| * query you wish to run on parent documents of the parent_type field. | |
| * query you wish to run on parent documents of the `parent_type` field |
| sealed trait HasParentQuery[S] extends ElasticQuery[S] with HasIgnoreUnmapped[HasParentQuery[S]] { | ||
| def withScore(value: Boolean): HasParentQuery[S] | ||
|
|
||
| def withScoreTrue: HasParentQuery[S] = withScore(true) |
There was a problem hiding this comment.
- Put
final defhere. - Put
withScoreFalsethenwithScoreTrue. - Should we put
withScore(...)in the new line?
There was a problem hiding this comment.
- We did not do it so far.
drmarjanovic
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
hasParentQueryin #91Summary: