(tests): Restructure ScriptSpec #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbulaja98
requested changes
Jun 24, 2023
dbulaja98
previously approved these changes
Jun 24, 2023
drmarjanovic
requested changes
Jun 24, 2023
| test("create script with source") { | ||
| val source = "doc['day_of_week'].value" | ||
| test("script") { | ||
| val source = "doc['day_of_week'].value" |
There was a problem hiding this comment.
Let's use:
val script = Script("doc['day_of_week'].value")
val scriptWithParams = Script("doc['day_of_week'].value * params['factor']").params("factor" -> 2)
vall scriptWithLangAndParams = Script(...)
| val script = Script("doc['day_of_week'].value") | ||
| val expected = | ||
| test("script") { | ||
| val scriptOnly = Script("doc['day_of_week'].value") |
There was a problem hiding this comment.
Let's have:
val script = ...
val scriptWithParams = ...
val scriptWithLang = ...
val scriptWithLangAndParams = ...
val expected = ...
val expectedWithParams = ...
val expectedWithLang = ...
...
drmarjanovic
previously approved these changes
Jun 24, 2023
drmarjanovic
changed the title
drmarjanovic
approved these changes
Jun 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Part of #251