(dsl): Support ids query
#271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipmilo
force-pushed
the
feature/id-query
branch
from
ed4f882
to
a583d9c
Compare
dbulaja98
requested changes
Jun 24, 2023
Comment on lines
754
to
766
|
|
||
| /** | ||
| * Constructs an instance of [[zio.elasticsearch.query.IdsQuery]] using the specified parameters. | ||
| * [[zio.elasticsearch.query.IdsQuery]] is used for matching documents containing a value that matches a provided | ||
| * pattern value. | ||
| * | ||
| * @param values | ||
| * array of values that will be used for the query | ||
| * @return | ||
| * an instance of [[zio.elasticsearch.query.IdsQuery]] that represents the ids query to be performed. | ||
| */ | ||
| final def ids(value: String, values: String*): Ids[Any] = | ||
| Ids(values = Chunk.fromIterable(value +: values)) |
There was a problem hiding this comment.
Can you update scaladoc (you are missing value now).
Comment on lines
866
to
868
| private[elasticsearch] final case class Ids[S]( | ||
| values: Chunk[String] | ||
| ) extends IdsQuery[S] { self => |
There was a problem hiding this comment.
Can this be in one line?
There was a problem hiding this comment.
Can you add tests for encoding too?
dbulaja98
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #91