Allow ElasticPrimitive types in term and terms query
#282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbulaja98
reviewed
Jul 7, 2023
| * @tparam S | ||
| * document for which field query is executed | ||
| * @return | ||
| * an instance of [[zio.elasticsearch.query.TermQuery]] that represents the term query to be performed. | ||
| */ | ||
| final def term[S](field: Field[S, String], value: String): TermQuery[S] = | ||
| final def term[S, A: ElasticPrimitive](field: Field[S, A], value: A): TermQuery[S] = |
There was a problem hiding this comment.
What do you think about leaving just _ instead of giving strict A: ElasticPrimitive?
There was a problem hiding this comment.
We use the same approach for matches query.
There was a problem hiding this comment.
I mean, we are limiting possible types for values. I wouldn't say we should allow passing an object as the argument.
drmarjanovic
force-pushed
the
fix-term-terms-query-allowed-type
branch
from
29034c6
to
e3e1431
Compare
mvelimir
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.