(dsl): Support matchPhrasePrefix query
#301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbulaja98
requested changes
Aug 15, 2023
| title: "Match Phrase Prefix Query" | ||
| --- | ||
|
|
||
| The `MatchPhrasePrefix` returns documents that contain the words of a provided text, in the same order as provided. |
There was a problem hiding this comment.
Suggested change
| The `MatchPhrasePrefix` returns documents that contain the words of a provided text, in the same order as provided. | |
| The `MatchPhrasePrefix` query returns documents that contain the words of a provided text, in the same order as provided. |
| val query: MatchPhrasePrefixQuery = matchPhrasePrefix(field = Document.stringField, value = "test") | ||
| ``` | ||
|
|
||
| You can find more information about `MatchPhrasePrefix` query [here](https://www.elastic.co/guide/en/elasticsearch/reference/7.17/query-dsl-match-query-phrase-prefix.html). |
There was a problem hiding this comment.
Put empty line at the end of the file.
| value = s"${firstDocument.stringField} te" | ||
| ) | ||
| res <- Executor.execute(ElasticRequest.search(firstSearchIndex, query)).documentAs[TestDocument] | ||
| } yield assert(res)(Assertion.contains(document)) |
There was a problem hiding this comment.
Maybe you can add && !contains(...) for other document?
| * @param field | ||
| * the type-safe field for which query is specified for | ||
| * @param value | ||
| * the value to be matched, represented by an instance of type `String` |
There was a problem hiding this comment.
Suggested change
| * the value to be matched, represented by an instance of type `String` | |
| * the text value to be matched |
| * @param field | ||
| * the field for which query is specified for | ||
| * @param value | ||
| * the value to be matched, represented by an instance of type `String` |
There was a problem hiding this comment.
Suggested change
| * the value to be matched, represented by an instance of type `String` | |
| * the text value to be matched |
Comment on lines
589
to
593
| private[elasticsearch] final case class MatchPhrasePrefix[S](field: String, value: String) | ||
| extends MatchPhrasePrefixQuery[S] { | ||
| private[elasticsearch] def toJson(fieldPath: Option[String]): Json = | ||
| Obj("match_phrase_prefix" -> Obj(fieldPath.foldRight(field)(_ + "." + _) -> value.toJson)) | ||
| } |
There was a problem hiding this comment.
Put empty line between.
Comment on lines
898
to
900
| assert(queryTs)( | ||
| equalTo(MatchPhrasePrefix[TestDocument](field = "stringField", value = "test")) | ||
| ) |
There was a problem hiding this comment.
Can this be in one line?
added 2 commits
August 15, 2023 13:11
dbulaja98
previously approved these changes
Aug 16, 2023
dbulaja98
previously approved these changes
Aug 16, 2023
petarcurcin
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #91