(dsl): Support Extended stats aggregation
#363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbulaja98
requested changes
Nov 14, 2023
|
|
||
| If you want to add aggregation (on the same level), you can use `withAgg` method: | ||
| ```scala | ||
| val multipleAggregations: MultipleAggregations = extendedStatsAggregation(name = "extendedStatsAggregation", field = Document.intField).withAgg(extendedStatsAggregation(name = "extendedStatsAggregation2", field = Document.doubleField)) |
There was a problem hiding this comment.
Suggested change
| val multipleAggregations: MultipleAggregations = extendedStatsAggregation(name = "extendedStatsAggregation", field = Document.intField).withAgg(extendedStatsAggregation(name = "extendedStatsAggregation2", field = Document.doubleField)) | |
| val multipleAggregations: MultipleAggregations = extendedStatsAggregation(name = "extendedStatsAggregation1", field = Document.intField).withAgg(extendedStatsAggregation(name = "extendedStatsAggregation2", field = Document.doubleField)) |
|
|
||
| /** | ||
| * Sets the `sigma` parameter for the [[zio.elasticsearch.aggregation.ExtendedStatsAggregation]]. The`sigma` parameter | ||
| * controls how many standard deviations plus/minus from the mean should std_deviation_bounds object display |
There was a problem hiding this comment.
Suggested change
| * controls how many standard deviations plus/minus from the mean should std_deviation_bounds object display | |
| * controls how many standard deviations plus/minus from the mean should std_deviation_bounds object display. |
| * @param value | ||
| * the value to use for sigma parameter | ||
| * @return | ||
| * an instance of the [[zio.elasticsearch.aggregation.ElasticAggregation]] enriched with the `sigma` parameter. |
There was a problem hiding this comment.
Maybe put reference for this aggregation instead of global ElasticAggregation.
| @@ -75,6 +105,38 @@ private[elasticsearch] object CardinalityAggregationResponse { | |||
| DeriveJsonDecoder.gen[CardinalityAggregationResponse] | |||
| } | |||
|
|
|||
| case class StdDeviationBounds private[elasticsearch] ( | |||
There was a problem hiding this comment.
Suggested change
| case class StdDeviationBounds private[elasticsearch] ( | |
| private[elasticsearch] case class StdDeviationBounds private[elasticsearch] ( |
Comment on lines
134
to
135
| implicit val boundsDecoder: JsonDecoder[StdDeviationBounds] = | ||
| DeriveJsonDecoder.gen[StdDeviationBounds] |
There was a problem hiding this comment.
Put this in separate object.
There was a problem hiding this comment.
And rename it to decoder.
| lower_sampling: Double | ||
| ) | ||
|
|
||
| private[elasticsearch] final case class ExtendedStatsAggregationResponse( |
There was a problem hiding this comment.
Please use Camel case. You can use this @jsonField("...") for specify name of json field.
| @@ -17,6 +17,7 @@ | |||
| package zio.elasticsearch.result | |||
|
|
|||
| import zio.Chunk | |||
| import zio.elasticsearch.executor.response.StdDeviationBounds | |||
There was a problem hiding this comment.
Create StdDeviationBoundsResult with same params, and map StdDeviationBounds to this new class. We are doing this duplication of code in the favour of privacy of the response layer (we don't want users to know about this layer).
| @@ -104,6 +104,48 @@ object HttpExecutorSpec extends IntegrationSpec { | |||
| Executor.execute(ElasticRequest.createIndex(firstSearchIndex)), | |||
| Executor.execute(ElasticRequest.deleteIndex(firstSearchIndex)).orDie | |||
| ), | |||
| test("aggregate using extended stats aggregation ttt") { | |||
There was a problem hiding this comment.
Suggested change
| test("aggregate using extended stats aggregation ttt") { | |
| test("aggregate using extended stats aggregation") { |
vanjaftn
force-pushed
the
task-support-extended-stats-aggregation
branch
from
2a1a584
to
0049424
Compare
dbulaja98
reviewed
Nov 15, 2023
Comment on lines
49
to
69
| ExtendedStatsAggregationResult( | ||
| count, | ||
| min, | ||
| max, | ||
| avg, | ||
| sum, | ||
| sumOfSquares, | ||
| variance, | ||
| variancePopulation, | ||
| varianceSampling, | ||
| stdDeviation, | ||
| stdDeviationPopulation, | ||
| stdDeviationSampling, | ||
| StdDeviationBoundsResult( | ||
| stdDeviationBoundsResponse.upper, | ||
| stdDeviationBoundsResponse.lower, | ||
| stdDeviationBoundsResponse.upperPopulation, | ||
| stdDeviationBoundsResponse.lowerPopulation, | ||
| stdDeviationBoundsResponse.upperSampling, | ||
| stdDeviationBoundsResponse.lowerSampling | ||
| ) |
There was a problem hiding this comment.
Name paramters since there are a lot of them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #118