(api): Support k-nearest neighbor (kNN) search #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnoldlacko
reviewed
Jan 21, 2024
modules/library/src/main/scala/zio/elasticsearch/executor/HttpExecutor.scala
Outdated
Show resolved
Hide resolved
arnoldlacko
reviewed
Jan 21, 2024
modules/library/src/main/scala/zio/elasticsearch/query/Queries.scala
Outdated
Show resolved
Hide resolved
arnoldlacko
reviewed
Jan 21, 2024
modules/library/src/main/scala/zio/elasticsearch/executor/HttpExecutor.scala
Outdated
Show resolved
Hide resolved
drmarjanovic
force-pushed
the
support-knn-search
branch
from
f184956
to
a3a7adc
Compare
arnoldlacko
approved these changes
Jan 22, 2024
mvelimir
approved these changes
Jan 22, 2024
dbulaja98
reviewed
Jan 22, 2024
| * @return | ||
| * an instance of [[zio.elasticsearch.query.KNNQuery]] that represents the kNN query to be performed. | ||
| */ | ||
| final def kNN[S](field: Field[S, _], k: Int, numCandidates: Int, queryVector: Chunk[Double]): KNNQuery[S] = |
There was a problem hiding this comment.
Maybe we could rename k to something more meaningful.
There was a problem hiding this comment.
I guess k makes more sense to users using it. Additionally, it's a kNN search.
modules/library/src/test/scala/zio/elasticsearch/domain/TestDocument.scala
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #381