Sort and refactor methods #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbulaja98
requested changes
Feb 4, 2024
| weight = None | ||
| ) | ||
|
|
||
| /** | ||
| * Constructs an instance of [[zio.elasticsearch.query.RandomScoreFunction]] using the specified parameters. | ||
| * [[zio.elasticsearch.query.RandomScoreFunction]] generates scores that are uniformly distributed from 0 up to but | ||
| * not including 1. By default, it uses the internal Lucene doc IDs as a source of randomness, which is very efficient | ||
| * not including 1. By default, it uses the internal Lucene doc ids as a source of randomness, which is very efficient |
There was a problem hiding this comment.
Suggested change
| * not including 1. By default, it uses the internal Lucene doc ids as a source of randomness, which is very efficient | |
| * not including 1. By default, it uses the internal Lucene doc IDs as a source of randomness, which is very efficient |
Comment on lines
540
to
548
| def filter[S1 <: S: Schema](filter: ElasticQuery[S1]): FieldValueFactor[S1] = | ||
| FieldValueFactor[S1]( | ||
| field = self.field, | ||
| factor = self.factor, | ||
| filter = Some(filter), | ||
| modifier = self.modifier, | ||
| missing = self.missing, | ||
| weight = self.weight | ||
| ) |
There was a problem hiding this comment.
Could you use self.copy(filter = Some(filter))?
Comment on lines
550
to
558
| def filter(value: ElasticQuery[Any]): FieldValueFactor[Any] = | ||
| FieldValueFactor( | ||
| field = self.field, | ||
| factor = self.factor, | ||
| filter = Some(value), | ||
| modifier = self.modifier, | ||
| missing = self.missing, | ||
| weight = self.weight | ||
| ) |
| @@ -627,6 +628,12 @@ private[elasticsearch] final case class RandomScoreFunction[S]( | |||
| weight: Option[Double] | |||
| ) extends FunctionScoreFunction[S] { self => | |||
|
|
|||
| def filter[S1 <: S: Schema](filter: ElasticQuery[S1]): RandomScoreFunction[S1] = | |||
| RandomScoreFunction[S1](Some(filter), seedAndField, weight) | |||
| val includes = if (included.isEmpty) Obj() else Obj("includes" -> Arr(included.map(_.toJson))) | ||
| val excludes = if (excluded.isEmpty) Obj() else Obj("excludes" -> Arr(excluded.map(_.toJson))) | ||
| Some(includes merge excludes) | ||
| case (Chunk(), Chunk()) => None |
There was a problem hiding this comment.
I guess we can put None in the new line, just to be consistent.
There was a problem hiding this comment.
We are. Everything is inlined here.
dbulaja98
approved these changes
Feb 5, 2024
mvelimir
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.