-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(executor): Fix refresh parameter #40
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnoldlacko
reviewed
Jan 11, 2023
modules/library/src/main/scala/zio/elasticsearch/HttpElasticExecutor.scala
Outdated
Show resolved
Hide resolved
arnoldlacko
requested changes
Jan 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we using toString
here on an Option?
arnoldlacko
reviewed
Jan 13, 2023
modules/library/src/it/scala/zio/elasticsearch/HttpExecutorSpec.scala
Outdated
Show resolved
Hide resolved
arnoldlacko
reviewed
Jan 13, 2023
modules/library/src/it/scala/zio/elasticsearch/HttpExecutorSpec.scala
Outdated
Show resolved
Hide resolved
arnoldlacko
reviewed
Jan 13, 2023
modules/library/src/it/scala/zio/elasticsearch/HttpExecutorSpec.scala
Outdated
Show resolved
Hide resolved
arnoldlacko
reviewed
Jan 13, 2023
modules/library/src/main/scala/zio/elasticsearch/HttpElasticExecutor.scala
Outdated
Show resolved
Hide resolved
dbulaja98
force-pushed
the
executor-fix-refresh-param
branch
from
January 16, 2023 10:45
cdb7256
to
f5271eb
Compare
drmarjanovic
requested changes
Jan 16, 2023
modules/library/src/main/scala/zio/elasticsearch/HttpElasticExecutor.scala
Outdated
Show resolved
Hide resolved
modules/library/src/test/scala/zio/elasticsearch/HttpElasticExecutorSpec.scala
Outdated
Show resolved
Hide resolved
modules/library/src/test/scala/zio/elasticsearch/HttpElasticExecutorSpec.scala
Outdated
Show resolved
Hide resolved
modules/library/src/test/scala/zio/elasticsearch/HttpElasticExecutorSpec.scala
Outdated
Show resolved
Hide resolved
modules/library/src/test/scala/zio/elasticsearch/HttpElasticExecutorSpec.scala
Outdated
Show resolved
Hide resolved
modules/library/src/test/scala/zio/elasticsearch/HttpElasticExecutorSpec.scala
Outdated
Show resolved
Hide resolved
modules/library/src/test/scala/zio/elasticsearch/HttpElasticExecutorSpec.scala
Outdated
Show resolved
Hide resolved
modules/library/src/test/scala/zio/elasticsearch/HttpElasticExecutorSpec.scala
Outdated
Show resolved
Hide resolved
modules/library/src/test/scala/zio/elasticsearch/HttpElasticExecutorSpec.scala
Outdated
Show resolved
Hide resolved
modules/library/src/test/scala/zio/elasticsearch/WiremockSpec.scala
Outdated
Show resolved
Hide resolved
dbulaja98
force-pushed
the
executor-fix-refresh-param
branch
from
January 16, 2023 14:28
bfc404a
to
871bf2f
Compare
drmarjanovic
requested changes
Jan 16, 2023
modules/library/src/test/scala/zio/elasticsearch/HttpElasticExecutorSpec.scala
Outdated
Show resolved
Hide resolved
modules/library/src/test/scala/zio/elasticsearch/WiremockSpec.scala
Outdated
Show resolved
Hide resolved
modules/library/src/test/scala/zio/elasticsearch/WiremockSpec.scala
Outdated
Show resolved
Hide resolved
modules/library/src/test/scala/zio/elasticsearch/WiremockSpec.scala
Outdated
Show resolved
Hide resolved
drmarjanovic
previously approved these changes
Jan 17, 2023
drmarjanovic
approved these changes
Jan 17, 2023
arnoldlacko
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.