Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builds failing with composer plugin error #32

Closed
javabudd opened this issue Nov 1, 2022 · 3 comments
Closed

Builds failing with composer plugin error #32

javabudd opened this issue Nov 1, 2022 · 3 comments
Labels
Bug Something isn't working
Milestone

Comments

@javabudd
Copy link

javabudd commented Nov 1, 2022

Bug Report

| Version(s) | 2.5.x

Summary

Builds against the 2.5.x branch (and possibly others) are failing due to a composer 2 security setting regarding allowable plugins. Example of a failed build that had no code changes and still failed. This could be happening on many Laminas libraries as it seems like it stems from laminas-ci-matrix-action.

Current behavior

All Github Actions builds are failing on the 2.5.x branch.

How to reproduce

Create a pull request into the 2.5.x branch to trigger a build.

Expected behavior

Builds should pass assuming no code changes have been made.

@javabudd javabudd added the Bug Something isn't working label Nov 1, 2022
@javabudd javabudd mentioned this issue Nov 1, 2022
@Ocramius
Copy link
Member

Ocramius commented Nov 1, 2022

Seems to just be an issue with very old composer.json, while composer/composer:^2.3 onwards broke BC by introducing required config for any plugins to be run.

This section needs adjustment:

"config": {
"sort-packages": true
},

Here's an example of how plugins are configured in laminas/laminas-servicemanager:

https://github.com/laminas/laminas-servicemanager/blob/166c5687ac2f48790fed854387327da28afbf088/composer.json#L23-L33

@Ocramius Ocramius added this to the 2.5.0 milestone Nov 1, 2022
@javabudd
Copy link
Author

javabudd commented Nov 1, 2022

Good find, I'll submit a PR to fix.

@javabudd
Copy link
Author

new PR that addresses the issue:

#35

@javabudd javabudd closed this as not planned Won't fix, can't repro, duplicate, stale Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants