-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow dealerdirect/phpcodesniffer-composer-installer plugin #33
Conversation
Signed-off-by: andyo <andy@servicecore.com>
Signed-off-by: andyo <andy@servicecore.com>
Updated PHPUnit to fix a build error with XSD failing on
|
Signed-off-by: andyo <andy@servicecore.com>
Updated phpunit to ^9.5.26, apparently the lowest version (somewhere around 9.2) is missing the phpunit.xsd spec. This change lines up with laminas/laminas-servicemanager (https://github.com/laminas/laminas-servicemanager/blob/3.20.x/composer.json#L47) |
I'm going to revert changes to the lockfile and redo the update, apparently all deps were updated |
Signed-off-by: andyo <andy@servicecore.com>
Ran the following command to update:
|
PHPCodeSniffer and Psalm checks are failing due to legitimate issues with the code. I will ignore those for now and we can address that in a separate PR. PHP8 lowest/latest builds are still failing and I'm not entirely sure why, will look into it. |
In order to get PHP8 builds working we need to allow doctrine-module @ ^4.0 and replace |
Declining in favor of #35 |
Addresses #32
Signed-off-by: andyo andy@servicecore.com
Description