Fix BC break in BcryptTrait #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `BcryptTrait` is a public API, changes to its method signatures can have a BC impact. In particular, the change to `checkPassword` for 1.7.0 was incorrect, as `$user` is an array, and because the signature is intended to match those in the oauth2-server sources. Additionally, some of the parameter annotations in oauth2-server class extensions were incorrect, and have been updated. Fixes #36 Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
BcryptTraitis a public API, changes to its method signatures can have a BC impact.In particular, the change to
checkPasswordfor 1.7.0 was incorrect, as$useris an array, and because the signature is intended to match those in the oauth2-server sources.Additionally, some of the parameter annotations in oauth2-server class extensions were incorrect, and have been updated.
Fixes #36