Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated composer.json so that composer scripts are compatible with bash, sh and windows shell #49

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

gildonei
Copy link
Contributor

@gildonei gildonei commented Feb 8, 2022

Q A
Bugfix yes

Description

Fixed post-create-project-cmd for windows by replacing single quotes for double quotes

Testing in Win 11 / php 7.4.9 cli using git clone / composer install

Signed-off-by: Gildonei M A Junior gildonei.mendes@gmail.com

|-------------- | ------
| Bugfix        | yes

### Description

Fixed _post-create-project-cmd_ for windows by replacing single quotes for double quotes

Testing in Win 11 / php 7.4.9 cli using git clone / composer install

Signed-off-by: Gildonei M A Junior <gildonei.mendes@gmail.com>
@gildonei
Copy link
Contributor Author

gildonei commented Feb 8, 2022

@froschdesign @Ocramius I really don't know how to solve the error with CI in PHP 7.3
I really appreciate if you could tell me what I have to do to pass all checks

Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified locally, thanks @gildonei!

@Ocramius Ocramius added the Bug Something isn't working label Feb 9, 2022
@Ocramius Ocramius added this to the 1.7.0 milestone Feb 9, 2022
@Ocramius Ocramius self-assigned this Feb 9, 2022
@Ocramius Ocramius changed the title Updated composer.json Updated composer.json so that composer scripts are compatible with bash, sh and windows shell Feb 9, 2022
@Ocramius Ocramius merged commit cff0def into laminas-api-tools:1.7.x Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants