Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSR-6 CacheItemPoolDecorator does not validate the maximum cache key length #156

Closed
boesing opened this issue Aug 5, 2021 · 4 comments · Fixed by #177
Closed

PSR-6 CacheItemPoolDecorator does not validate the maximum cache key length #156

boesing opened this issue Aug 5, 2021 · 4 comments · Fixed by #177
Milestone

Comments

@boesing
Copy link
Member

boesing commented Aug 5, 2021

Feature Request

Q A
New Feature yes
BC Break yes

Summary

As per PSR-6, a minimum cache key length of 64 characters have to be supported by the underlying storage.
The maximum can vary and depends on the implementing library.

For PSR-16 there was already a bugfix which allowed cache keys longer than 64 characters but for the CacheItemPoolDecorator, there is no such validation.

@boesing boesing added this to the 3.0.0 milestone Aug 5, 2021
@boesing
Copy link
Member Author

boesing commented Aug 5, 2021

Relates to #154

@froschdesign
Copy link
Member

Is this problem solved with #158 and released with 2.12.2?

@boesing
Copy link
Member Author

boesing commented Oct 21, 2021

Oh I guess yes. It was fixed with v2.12.0 probably. Thanks for the ping 👍🏼

@boesing boesing closed this as completed Oct 21, 2021
@boesing
Copy link
Member Author

boesing commented Oct 21, 2021

Ah no, this is PSR-6 related. The changes were made to PSR-16 which already had some kind of maximum key length validation but PSR-6 haven't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants