PSR-6 maximum cache key length validation #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
…item pool decorator Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
…d PSR-16 decorators Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
…tion of v3 This also provides breaking changes information which belong to internal code which should not affect upstream projects. Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
… a camel cased property according to codestyle Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
boesing
deleted the
feature/psr-6-maximum-cache-key-length-validation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the maximum cache key length validation feature which was already part of the
PSR-16SimpleCacheDecorator.Since both PSR-6 and PSR-16 have the same requirements regarding cache key length, the logic was extract to a dedicated (
internal)MaximumKeyLength-Trait.Since this validation was not part of the
CacheItemPoolDecoratorbefore, this is supposed to be a BC break.Besides this, I've also marked the
Laminas\Cache\Psr\SerializationTraitasinternal.Fixes #156