-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark ClassCache
pattern as deprecated
#118
Mark ClassCache
pattern as deprecated
#118
Conversation
It should be marked as deprecated in documentation as well : https://github.com/laminas/laminas-cache/blob/2.12.x/docs/book/pattern/class-cache.md |
Probably also trigger a deprecation notice on class loading or initializing ? |
Ive thought it would be a good thing as well when introducing the new Interfaces for plugins but there, the notice was only triggered when upstream did not implemented the There were some complaints from @Ocramius about having runtime effects in deprecations and thus I try to avoid these now as I see the point. Actually, there is not even an alternative to this and thus no way of fixing the deprecation message unless someone copys the code and removes the message. What do you think? |
Fine for me. At least the current documentation and (upcoming) migration guide should include this deprecation/removal. |
@froschdesign Is there some "standard" to mark something as deprecated in the documentation? |
@boesing
The block should be placed directly after the headline. It would be good if an alternative with a link could be added. |
@froschdesign Sadly, there is no alternative yet. I am thinking about creating a pattern which can be used in combination with PSR-6 to have such cache logic again but that is not yet implemented. |
f270508
to
944d7ed
Compare
944d7ed
to
dc83482
Compare
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
dc83482
to
73f4eb5
Compare
ClassCache
pattern as deprecatedClassCache
pattern as deprecated
Description
As recommended by @marc-mabe in #107, we mark the
ClassCache
as deprecated as of v2.12.