fix: consider missing indices in array

Signed-off-by: Thomas Rieschl <thomas@trinet.at>
laminas · Apr 23, 2021 · fa9d202 · fa9d202
1 parent 67dc6c0
commit fa9d202
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 1 deletion.
diff --git a/src/Generator/PropertyGenerator.php b/src/Generator/PropertyGenerator.php
@@ -35,7 +35,7 @@ public static function fromReflection(PropertyReflection $reflectionProperty)
 
         $allDefaultProperties = $reflectionProperty->getDeclaringClass()->getDefaultProperties();
 
-        $defaultValue = $allDefaultProperties[$reflectionProperty->getName()];
+        $defaultValue = $allDefaultProperties[$reflectionProperty->getName()] ?? null;
         $property->setDefaultValue($defaultValue);
         if ($defaultValue === null) {
             $property->omitDefaultValue = true;

diff --git a/test/Generator/PropertyGeneratorTest.php b/test/Generator/PropertyGeneratorTest.php
@@ -16,6 +16,8 @@
 use Laminas\Code\Generator\PropertyValueGenerator;
 use Laminas\Code\Generator\ValueGenerator;
 use Laminas\Code\Reflection\ClassReflection;
+use Laminas\Code\Reflection\PropertyReflection;
+use LaminasTest\Code\Generator\TestAsset\ClassWithTypedProperty;
 use PHPUnit\Framework\TestCase;
 use ReflectionProperty;
 use stdClass;
@@ -324,4 +326,14 @@ public function testFromReflectionOmitsDefaultValueIfItIsNull(): void
 
         $this->assertSame('    public static $fooStaticProperty;', $code);
     }
+
+    public function testFromReflectionOmitsTypeHintInTypedProperty(): void
+    {
+        $reflectionProperty = new PropertyReflection(ClassWithTypedProperty::class, 'typedProperty');
+
+        $generator = PropertyGenerator::fromReflection($reflectionProperty);
+        $code      = $generator->generate();
+
+        self::assertSame('    public $typedProperty;', $code);
+    }
 }
diff --git a/test/Generator/TestAsset/ClassWithTypedProperty.php b/test/Generator/TestAsset/ClassWithTypedProperty.php
@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+namespace LaminasTest\Code\Generator\TestAsset;
+
+final class ClassWithTypedProperty
+{
+    public string $typedProperty;
+}