Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use static data providers in preparation for PHPUnit 10 #160

Merged
merged 1 commit into from
Nov 25, 2022

Conversation

IonBazan
Copy link
Contributor

Q A
Documentation no
Bugfix no
BC Break no
New Feature no
RFC no
QA no

Description

Refactoring tests data providers to be static (to prepare for upcoming PHPUnit 10 changes: sebastianbergmann/phpunit@9caafe2)

Signed-off-by: Ion Bazan <ion.bazan@gmail.com>
@IonBazan IonBazan changed the title Use static data providers [Tests][Refactor] Use static data providers Nov 24, 2022
@Ocramius Ocramius added this to the 4.8.0 milestone Nov 25, 2022
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Ocramius Ocramius self-assigned this Nov 25, 2022
@Ocramius Ocramius changed the title [Tests][Refactor] Use static data providers Use static data providers in preparation for PHPUnit 10 Nov 25, 2022
@Ocramius Ocramius merged commit 224f5d7 into laminas:4.8.x Nov 25, 2022
@IonBazan IonBazan deleted the tests/static-providers branch November 26, 2022 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants