Allow enum value to be backed by an empty string #189
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the
EnumGenerator
class enforces (in its Psalm typings) that a case of a backed enumeration is backed byint|non-empty-string
. However, thenon-empty-string
constraint is unnecessarily strict, since (AFAIK)an empty string is an entirely valid value (not name!) for a backed enum case.
This change relaxes the Psalm type hints a bit in order to allow this: