Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest "laminas/laminas-zendframework-bridge" #39

Closed
wants to merge 30 commits into from
Closed

Suggest "laminas/laminas-zendframework-bridge" #39

wants to merge 30 commits into from

Conversation

olvlvl
Copy link
Contributor

@olvlvl olvlvl commented Apr 20, 2020

Q A
Documentation no
Bugfix no
BC Break yes
New Feature no
RFC no
QA no

Description

Hi everyone,

With this PR, laminas/laminas-zendframework-bridge becomes a suggestion rather than a requirement.

We're trying to keep our bootstrap time as small as possible and this is not helping. One of our dependency uses ocramius/proxy-manager, which uses laminas-code, but we're not using Zend Framework.

Right now, we added this to our composer.json, but of course, a cleaner solution would be welcome:

    "replace": {
        "laminas/laminas-zendframework-bridge": "^1.0"
    },

michalbundyra and others added 29 commits December 10, 2019 18:21
Drop unused `use function strstr` in ClassGenerator
Signed-off-by: Michał Bundyra <contact@webimpress.com>
Signed-off-by: Michał Bundyra <contact@webimpress.com>
Signed-off-by: Michał Bundyra <contact@webimpress.com>
Signed-off-by: Michał Bundyra <contact@webimpress.com>
@weierophinney weierophinney added this to the 4.0.0 milestone Apr 20, 2020
@weierophinney
Copy link
Member

Unfortunately, we cannot do this until the next major release.

In order for our component packages to act as replacements of the original ZF packages, users must be able to install them in place of the original package, without otherwise changing their code. This means that if user code references a Zend\Code class, that code must continue to work after swapping packages.

The way we made this work was with the laminas-zendframework-bridge package, which adds autoloading rules to create class_alias entries for ZF classes that are now served by Laminas. Making the bridge a suggestion would cause the package to no longer work as a replacement, and is thus a BC break.

I'm going to leave this PR open, but have it target next major. I don't have a timeline for when we will do such a release, however. You will also need to rebase against develop, and change the target branch accordingly.

@olvlvl olvlvl changed the base branch from master to develop April 20, 2020 16:21
Signed-off-by: Olivier Laviale <olivier.laviale@gmail.com>
@olvlvl
Copy link
Contributor Author

olvlvl commented Apr 20, 2020

I updated "BC Break" to "yes" and rebased against "develop". We'll keep our little hack for now.

@geerteltink geerteltink changed the base branch from develop to 4.0.x September 11, 2020 13:19
@Ocramius Ocramius self-assigned this Nov 30, 2020
Ocramius added a commit that referenced this pull request Nov 30, 2020
@Ocramius Ocramius closed this in 765d88d Nov 30, 2020
@Ocramius
Copy link
Member

Ocramius commented Nov 30, 2020

Manually merged via 765d88d (cherry-picked into a new branch)

@olvlvl olvlvl deleted the olvlvl-suggest-laminas-zendframework-bridge branch November 30, 2020 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants