Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some constants are not rendered properly depending on environment values #50

Merged
merged 3 commits into from
Nov 30, 2020
Merged

Some constants are not rendered properly depending on environment values #50

merged 3 commits into from
Nov 30, 2020

Conversation

drupol
Copy link
Contributor

@drupol drupol commented Nov 18, 2020

This PR:

@drupol
Add new test.
725266f 
Signed-off-by: Pol Dellaiera <pol.dellaiera@protonmail.com>
@drupol
Fix issue.
779d93c 
Signed-off-by: Pol Dellaiera <pol.dellaiera@protonmail.com>
@drupol
Improvements.
9a4a168 
Signed-off-by: Pol Dellaiera <pol.dellaiera@protonmail.com>
@Ocramius Ocramius added the Bug Something isn't working label Nov 30, 2020
@Ocramius Ocramius self-assigned this Nov 30, 2020
@Ocramius Ocramius added this to the 4.0.0 milestone Nov 30, 2020
@Ocramius Ocramius changed the title Some constants are not rendered properly Some constants are not rendered properly depending on environment values Nov 30, 2020
@Ocramius
Copy link
Member

Indeed a bug: thanks @drupol!

@Ocramius Ocramius merged commit c35fb76 into laminas:4.0.x Nov 30, 2020
@drupol drupol deleted the 49-fix-constants-inconsistency branch November 30, 2020 13:18
@drupol
Copy link
Contributor Author

drupol commented Nov 30, 2020

Grazie ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ocramius Ocramius

Labels
Bug Something isn't working
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Some constants are not rendered properly
2 participants
@drupol @Ocramius