Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #45 : Psalm integration #61

Merged
merged 1 commit into from
Dec 9, 2020
Merged

fix #45 : Psalm integration #61

merged 1 commit into from
Dec 9, 2020

Conversation

fezfez
Copy link
Contributor

@fezfez fezfez commented Dec 1, 2020 •
edited by Ocramius
Loading

Resolves #45

@fezfez
Copy link
Contributor Author

fezfez commented Dec 6, 2020

@weierophinney @Ocramius
can you check this please?
Thanks!

@Ocramius Ocramius self-assigned this Dec 9, 2020
@Ocramius Ocramius added this to the 4.0.0 milestone Dec 9, 2020
@Ocramius Ocramius linked an issue Dec 9, 2020 that may be closed by this pull request
Psalm integration #45
Closed
8 tasks
@Ocramius Ocramius mentioned this pull request Dec 9, 2020
Closed
8 tasks
Ocramius
Ocramius approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Ocramius Ocramius merged commit 1735224 into laminas:4.0.x Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
Enhancement
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Psalm integration
2 participants
@fezfez @Ocramius