-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure variadic parameter does not have default value #72
Make sure variadic parameter does not have default value #72
Conversation
Signed-off-by: Michael Chekin <mchekin@gmail.com>
This reverts commit 6c6eae8. Signed-off-by: Michael Chekin <mchekin@gmail.com>
…nges) Signed-off-by: Michael Chekin <mchekin@gmail.com>
Signed-off-by: Michael Chekin <mchekin@gmail.com>
…aultValueThrowsInvalidArgumentException Signed-off-by: Michael Chekin <mchekin@gmail.com>
Signed-off-by: Michael Chekin <mchekin@gmail.com>
… of during the parameter generation. Signed-off-by: Michael Chekin <mchekin@gmail.com>
3ec81d9
to
d031130
Compare
@Ocramius |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @mchekin!
Almost one year after ) |
@lisachenko test cases please :) |
@lisachenko is right and I am unable to use the goaop framework due to this issue. Please fix it, thanks. The issues seems simple
The function should not throw exception, when $variadic is false. e. g
|
@sakhunzai send a patch with an attached test, please. |
Description
Related to issue #35