Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Composer-Require-Checker and Infection to CI. PHP requirement bumped to 7.4 #30

Merged
merged 14 commits into from
Mar 8, 2022
Merged

Adds Composer-Require-Checker and Infection to CI. PHP requirement bumped to 7.4 #30

merged 14 commits into from
Mar 8, 2022

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented Mar 8, 2022 •
edited
Loading

Q A
Documentation yes
Bugfix no
BC Break no
New Feature no
RFC no
QA yes

Description

  • Declares ext-ctype as a dependency
  • enables composer require checker
  • enables infection
  • Removes usage of iconv in preference of a hard dependency on mbstring
  • Fixes/Ignores Markdown lint error causing CI to fail
  • Bumps minimum support PHP version to 7.4
  • Fixes all remaining psalm errors

@gsteel gsteel force-pushed the require-checker branch from 5d8289a to cc1504a Compare March 8, 2022 10:22
Ocramius
Ocramius requested changes Mar 8, 2022
View reviewed changes
composer-require-checker.json Outdated Show resolved Hide resolved
@gsteel gsteel requested a review from Ocramius March 8, 2022 12:19
Ocramius
Ocramius requested changes Mar 8, 2022
View reviewed changes
composer.json Show resolved Hide resolved
infection.json.dist Outdated Show resolved Hide resolved
infection.json.dist Outdated Show resolved Hide resolved
psalm.xml Show resolved Hide resolved
@Ocramius Ocramius added this to the 2.10.0 milestone Mar 8, 2022
gsteel
gsteel commented Mar 8, 2022
View reviewed changes
src/Escaper.php Outdated Show resolved Hide resolved
@gsteel gsteel changed the title Adds Composer-Require-Checker to CI Adds Composer-Require-Checker and Infection to CI. PHP requirement bumped to 7.4 Mar 8, 2022
@gsteel gsteel requested a review from Ocramius March 8, 2022 17:49
Ocramius
Ocramius approved these changes Mar 8, 2022
View reviewed changes
infection.json.dist Outdated Show resolved Hide resolved
src/Escaper.php Show resolved Hide resolved
src/Escaper.php Outdated Show resolved Hide resolved
gsteel added 14 commits March 8, 2022 19:32
@gsteel
Adds configuration to trigger composer require checker qa job
a28dcd6 
Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel
Declares ctype as a required extension and lists permitted plugins
288cf00 
Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel
Adjust require checker configuration to whitelist iconv and mbstring …
f9e22a2 
…which are tested prior to use

Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel
Fixes markdown lint error causing CI to fail
b18f979 
Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel
Declares mbstring as a dependency and removes iconv usage. Bumps mini…
35a2099 
…mum PHP to 7.4

Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel
Update dev dependencies and fix psalm low-hanging fruit
cb83527 
Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel
Modify data providers to solve XML code coverage generation errors du…
646b805 
…e to unusual codepoints and enable infection

Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel
Fix remaining psalm errors and update baseline
863f5c9 
Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel
Update .gitattributes to ignore dot-files and remove coveralls config
7384651 
Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel
Remove irrelevant exclusions
30bbffb 
Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel
Print infection logs to stdout and GitHub actions format
2d34546 
Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel
Revert function wrappers for psalm. Not required when types align cor…
898b7d1 
…rectly

Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel
Add stryker report config for infection
01c382a 
Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel
Fix markdown lint errors for CI. Remove coverage badge
85ce59a 
Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel gsteel force-pushed the require-checker branch from 35c7c56 to 85ce59a Compare March 8, 2022 19:34
@gsteel
Copy link
Member Author

gsteel commented Mar 8, 2022

@Ocramius - I've taken care of the remaining issues and rebased so that markdown-lint passes - hopefully this one is good to go now!

Ocramius
Ocramius approved these changes Mar 8, 2022
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gsteel!

@Ocramius Ocramius self-assigned this Mar 8, 2022
@Ocramius Ocramius merged commit 58af672 into laminas:2.10.x Mar 8, 2022
@gsteel gsteel deleted the require-checker branch March 8, 2022 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
Enhancement
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gsteel @Ocramius