Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General Maintenance #39

Merged
merged 5 commits into from
Oct 10, 2022
Merged

General Maintenance #39

merged 5 commits into from
Oct 10, 2022

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented Oct 10, 2022

Q A
QA yes

Description

  • General cleanup of test case
  • Remove CI configuration to ignore platform requirements
  • Update export-ignores
  • Add a test covering successful encoding conversion

gsteel added 4 commits October 10, 2022 10:38
@gsteel
General test case cleanup - call static methods statically
e853331 
Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel
platform requirements should not be ignored
09cfc21 
Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel
Add a test to cover internal encoding conversion
3f12db4 
Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel
Update ignores
be7a3ef 
Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel gsteel added this to the 2.12.0 milestone Oct 10, 2022
@gsteel
CS Fix
c4fd955 
Signed-off-by: George Steel <george@net-glue.co.uk>
@Ocramius Ocramius self-assigned this Oct 10, 2022
@Ocramius Ocramius merged commit ee7a4c3 into laminas:2.12.x Oct 10, 2022
@gsteel gsteel deleted the test-uncovered branch October 10, 2022 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
Enhancement
Projects
None yet
Milestone
2.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gsteel @Ocramius