Upgrade PHPUnit to 10.1.x #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ughh. Infection won't pass without laminas/laminas-continuous-integration-action#130 |
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
…-action#130 is finished Signed-off-by: George Steel <george@net-glue.co.uk>
|
@Ocramius I've disabled infection here so that the PHPUnit 10 upgrade can go through. Would it be preferable to manually add a job to CI that doesn't use the laminas container or can we just re-enable it when phpdbg is dropped from the CI container? |
|
IMO going from PHPUnit 9 to PHPUnit 10 and losing infection is worse than keeping on PHPUnit 9, for now 🤔 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs #46
Closes #43