-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor unit-tests action to automate test matrix #15
Refactor unit-tests action to automate test matrix #15
Conversation
34fc4fb
to
47feb9c
Compare
Version 1.0.0 of laminas-coding-standard is the problem here because it uses an old version of PHP_CodeSniffer. |
0ccd585
to
2a5df5b
Compare
a0f81bd
to
583a5bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, this looks awesome.
Can't wait to use it in the other packages.
Just one thing regarding ignoring platform reqs as we should only ignore PHP probably (composer v2 is used here) and maybe there is a way to make some "variables" global to re-use them in multiple steps (such as composer args).
a83f3a5
to
d4fb375
Compare
6f76a1d
to
b6f0db1
Compare
b6f0db1
to
1f91cf1
Compare
pull_request: | ||
push: | ||
branches: | ||
- '[0-9]+.[0-9]+.x' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am curious.
Do we really need it on the release branches?
These are only changed from PRs which are already passing CI.
Imho, this is unnecessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good to have a sanity check.
Adopts workflow prototyped in laminas/laminas-eventmanager#15 - mainly to check that Psalm integration works as expected. Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
This patch adopts the workflow as described by [laminas/laminas-ci-matrix-action](https://github.com/laminas/laminas-ci-matrix-action). Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
0690820
to
8cdf6d2
Compare
This patch adopts the laminas/laminas-continuous-integration-action for its CI workflow. As demonstrated, the workflow picks up:
and notably omits Psalm checks, as we don't have Psalm support yet.