Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor unit-tests action to automate test matrix #15

Merged

Conversation

weierophinney
Copy link
Member

@weierophinney weierophinney commented Jan 27, 2021

This patch adopts the laminas/laminas-continuous-integration-action for its CI workflow. As demonstrated, the workflow picks up:

  • All PHP combinations with lowest/latest test runs
  • CS checks
  • Benchmarks

and notably omits Psalm checks, as we don't have Psalm support yet.

@weierophinney weierophinney force-pushed the feature/github-actions-automatrix branch 2 times, most recently from 34fc4fb to 47feb9c Compare January 27, 2021 21:12
@froschdesign
Copy link
Member

@weierophinney

PHP Fatal error: Array and string offset access syntax with curly braces is no longer supported

Version 1.0.0 of laminas-coding-standard is the problem here because it uses an old version of PHP_CodeSniffer.

.github/workflows/continuous-integration.yml Outdated Show resolved Hide resolved
.github/workflows/continuous-integration.yml Outdated Show resolved Hide resolved
.github/workflows/continuous-integration.yml Outdated Show resolved Hide resolved
@weierophinney weierophinney force-pushed the feature/github-actions-automatrix branch 4 times, most recently from a0f81bd to 583a5bc Compare January 28, 2021 17:04
Copy link
Member

@boesing boesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this looks awesome.
Can't wait to use it in the other packages.

Just one thing regarding ignoring platform reqs as we should only ignore PHP probably (composer v2 is used here) and maybe there is a way to make some "variables" global to re-use them in multiple steps (such as composer args).

.github/workflows/continuous-integration.yml Outdated Show resolved Hide resolved
.github/workflows/continuous-integration.yml Outdated Show resolved Hide resolved
@weierophinney weierophinney force-pushed the feature/github-actions-automatrix branch 3 times, most recently from a83f3a5 to d4fb375 Compare January 28, 2021 18:22
@weierophinney weierophinney force-pushed the feature/github-actions-automatrix branch 10 times, most recently from 6f76a1d to b6f0db1 Compare January 28, 2021 22:29
@weierophinney weierophinney force-pushed the feature/github-actions-automatrix branch from b6f0db1 to 1f91cf1 Compare January 28, 2021 22:32
.github/workflows/continuous-integration-config.json Outdated Show resolved Hide resolved
.github/workflows/continuous-integration.yml Outdated Show resolved Hide resolved
.github/workflows/continuous-integration.yml Outdated Show resolved Hide resolved
.github/workflows/continuous-integration.yml Outdated Show resolved Hide resolved
.github/workflows/continuous-integration.yml Outdated Show resolved Hide resolved
.github/workflows/continuous-integration.yml Outdated Show resolved Hide resolved
.github/workflows/continuous-integration.yml Outdated Show resolved Hide resolved
.github/workflows/continuous-integration.yml Outdated Show resolved Hide resolved
.github/workflows/continuous-integration.yml Outdated Show resolved Hide resolved
.github/workflows/continuous-integration.yml Show resolved Hide resolved
pull_request:
push:
branches:
- '[0-9]+.[0-9]+.x'
Copy link
Member

@boesing boesing Feb 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am curious.
Do we really need it on the release branches?
These are only changed from PRs which are already passing CI.
Imho, this is unnecessary.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good to have a sanity check.

.github/workflows/continuous-integration.yml Show resolved Hide resolved
weierophinney added a commit to weierophinney/laminas-feed that referenced this pull request Feb 8, 2021
Adopts workflow prototyped in laminas/laminas-eventmanager#15 - mainly to check that Psalm integration works as expected.

Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
This patch adopts the workflow as described by [laminas/laminas-ci-matrix-action](https://github.com/laminas/laminas-ci-matrix-action).

Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
@weierophinney weierophinney force-pushed the feature/github-actions-automatrix branch from 0690820 to 8cdf6d2 Compare February 10, 2021 16:23
@weierophinney weierophinney merged commit 0cb5459 into laminas:3.4.x Feb 10, 2021
@weierophinney weierophinney deleted the feature/github-actions-automatrix branch February 10, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants