Fixes #22: "ComposedObject" Annotation does not add inputSpec to element configuration #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raul Robledo <riul88@gmail.com>
Signed-off-by: Raul Robledo <riul88@gmail.com>
Signed-off-by: Raul Robledo <riul88@gmail.com>
Ocramius
requested changes
Mar 11, 2023
Comment on lines
+224
to
+245
| $usernameInput = $composed->get('username'); | ||
| self::assertInstanceOf(Input::class, $usernameInput); | ||
| $validatorChain = $usernameInput->getValidatorChain(); | ||
| self::assertInstanceOf(ValidatorChain::class, $validatorChain); | ||
| $usernameValidators = $validatorChain->getValidators(); | ||
| self::assertCount(2, $usernameValidators); | ||
| self::assertInstanceOf(NotEmpty::class, $usernameValidators[0]['instance']); | ||
| self::assertInstanceOf(StringLength::class, $usernameValidators[1]['instance']); | ||
| $usernameFilters = $usernameInput->getFilterChain()->getFilters()->toArray(); | ||
| self::assertCount(1, $usernameFilters); | ||
| self::assertInstanceOf(StringTrim::class, $usernameFilters[0]); | ||
|
|
||
| $passwordInput = $composed->get('password'); | ||
| self::assertInstanceOf(Input::class, $passwordInput); | ||
| $validatorChain = $passwordInput->getValidatorChain(); | ||
| $passwordValidators = $validatorChain->getValidators(); | ||
| self::assertCount(1, $passwordValidators); | ||
| self::assertInstanceOf(EmailAddress::class, $passwordValidators[0]['instance']); | ||
|
|
||
| $passwordFilters = $passwordInput->getFilterChain()->getFilters()->toArray(); | ||
| self::assertCount(1, $passwordFilters); | ||
| self::assertInstanceOf(StringTrim::class, $passwordFilters[0]); |
There was a problem hiding this comment.
Can we split it out to a smaller test highlighting just what is being fixed? 🤔
There was a problem hiding this comment.
Without the fix, username and password result indeed with no validator at all, wrongfully.
froschdesign
changed the title
Slamdunk
approved these changes
Mar 13, 2023
Comment on lines
+224
to
+245
| $usernameInput = $composed->get('username'); | ||
| self::assertInstanceOf(Input::class, $usernameInput); | ||
| $validatorChain = $usernameInput->getValidatorChain(); | ||
| self::assertInstanceOf(ValidatorChain::class, $validatorChain); | ||
| $usernameValidators = $validatorChain->getValidators(); | ||
| self::assertCount(2, $usernameValidators); | ||
| self::assertInstanceOf(NotEmpty::class, $usernameValidators[0]['instance']); | ||
| self::assertInstanceOf(StringLength::class, $usernameValidators[1]['instance']); | ||
| $usernameFilters = $usernameInput->getFilterChain()->getFilters()->toArray(); | ||
| self::assertCount(1, $usernameFilters); | ||
| self::assertInstanceOf(StringTrim::class, $usernameFilters[0]); | ||
|
|
||
| $passwordInput = $composed->get('password'); | ||
| self::assertInstanceOf(Input::class, $passwordInput); | ||
| $validatorChain = $passwordInput->getValidatorChain(); | ||
| $passwordValidators = $validatorChain->getValidators(); | ||
| self::assertCount(1, $passwordValidators); | ||
| self::assertInstanceOf(EmailAddress::class, $passwordValidators[0]['instance']); | ||
|
|
||
| $passwordFilters = $passwordInput->getFilterChain()->getFilters()->toArray(); | ||
| self::assertCount(1, $passwordFilters); | ||
| self::assertInstanceOf(StringTrim::class, $passwordFilters[0]); |
There was a problem hiding this comment.
Without the fix, username and password result indeed with no validator at all, wrongfully.
| 'name' => 'EmailAddress', | ||
| ], | ||
| ], | ||
| ], $passwordFilterSpec); |
There was a problem hiding this comment.
This test passes even without the fix though, but I like it has been added.
weierophinney
approved these changes
Mar 13, 2023
There was a problem hiding this comment.
🚢
@Slamdunk Since you're official maintainer for this component now, I'll let you merge.
|
Thank you @riul88 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Raul Robledo riul88@gmail.com
Description
Fix suggested by @weierophinney
Issue reproducible by unit test testAllowsComposingChildEntities but the test case didn't validate the filters or validators from the child entity, the unit test was updated as part of this PR to perform the missing assertions to ensure the element validators and filters are configured
The changes to unit test testAllowsComposingMultipleChildEntities which is used when ComposedObject is marked as isCollection are only preventive not impacted by the code change in the PR