-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for PHP 8.0, add support for PHP 8.3 #80
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a full revert with the exception of adding 8.3 to the list of compatible PHP versions.
I believe that most of the dependencies here now have 8.3 compatible releases.
If composer still refuses to install dependencies, you can try adding .laminas-ci.json
to the root of the project with:
{
"ignore_php_platform_requirements": {
"8.3": true
}
}
@gsteel Can you suggest about README Linting and Documentation Linting failures? |
The README has trailing spaces and the issue with the docs is the header increment jumps from a level 1 or 2 to a level 4 heading (it should probably be a level 2 or 3 heading depending on context). See the linting errors in CI: https://github.com/laminas/laminas-http/actions/runs/6707197515 |
@glo71317 > #### Known issue with libcurl prior to 7.30.0 to 3: > ### Known issue with libcurl prior to 7.30.0 laminas-http/docs/book/client/adapters.md Line 244 in 76de900
|
@gsteel @froschdesign I have fixed linting issues, Can you please review the changes and proceed for merging if there is not an issue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @glo71317
"laminas/laminas-loader": "^2.10", | ||
"laminas/laminas-stdlib": "^3.6", | ||
"laminas/laminas-uri": "^2.9.1", | ||
"laminas/laminas-uri": "^2.11", | ||
"laminas/laminas-validator": "^2.15" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would prefer not to bump direct dependencies without a specific reason here.
Description