Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for PHP 8.0, add support for PHP 8.3 #80

Merged
merged 3 commits into from
Nov 2, 2023

Conversation

glo71317
Copy link
Contributor

Q A
Documentation yes/no
Bugfix yes/no
BC Break yes/no
New Feature yes/no
RFC yes/no
QA yes/no

Description

Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a full revert with the exception of adding 8.3 to the list of compatible PHP versions.

I believe that most of the dependencies here now have 8.3 compatible releases.

If composer still refuses to install dependencies, you can try adding .laminas-ci.json to the root of the project with:

{
     "ignore_php_platform_requirements": {
        "8.3": true
     }
}

@glo71317
Copy link
Contributor Author

@gsteel Can you suggest about README Linting and Documentation Linting failures?

@gsteel
Copy link
Member

gsteel commented Oct 31, 2023

The README has trailing spaces and the issue with the docs is the header increment jumps from a level 1 or 2 to a level 4 heading (it should probably be a level 2 or 3 heading depending on context).

See the linting errors in CI: https://github.com/laminas/laminas-http/actions/runs/6707197515

@froschdesign
Copy link
Member

@glo71317
Change the headline level from 4:

> #### Known issue with libcurl prior to 7.30.0

to 3:

> ### Known issue with libcurl prior to 7.30.0

> #### Known issue with libcurl prior to 7.30.0

@glo71317
Copy link
Contributor Author

glo71317 commented Nov 2, 2023

@gsteel @froschdesign I have fixed linting issues, Can you please review the changes and proceed for merging if there is not an issue?

Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @glo71317

Comment on lines +27 to 30
"laminas/laminas-loader": "^2.10",
"laminas/laminas-stdlib": "^3.6",
"laminas/laminas-uri": "^2.9.1",
"laminas/laminas-uri": "^2.11",
"laminas/laminas-validator": "^2.15"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would prefer not to bump direct dependencies without a specific reason here.

@gsteel gsteel self-assigned this Nov 2, 2023
@gsteel gsteel added this to the 2.19.0 milestone Nov 2, 2023
@gsteel gsteel changed the title PHP 8.3 support added Remove support for PHP 8.0, add support for PHP 8.3 Nov 2, 2023
@gsteel gsteel merged commit 26dd6d1 into laminas:2.19.x Nov 2, 2023
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants