Removes deprecation messages which lead to irritation because there are no alternative paths for implementation

[froschdesign]

The current deprecations of methods and properties cannot be resolved or bypassed by other options or workarounds. The isValid method of the Input class uses and needs these deprecated methods and properties:

laminas-inputfilter/src/Input.php

Lines 370 to 405 in 2e9a2f2

	public function isValid($context = null)
	{
	if (is_array($this->errorMessage)) {
	$this->errorMessage = null;
	}
	$value = $this->getValue();
	$hasValue = $this->hasValue();
	$empty = $value === null || $value === '' || $value === [];
	$required = $this->isRequired();
	$allowEmpty = $this->allowEmpty();
	$continueIfEmpty = $this->continueIfEmpty();
	if (! $hasValue && $this->hasFallback()) {
	$this->setValue($this->getFallbackValue());
	return true;
	}
	if (! $hasValue && ! $required) {
	return true;
	}
	if (! $hasValue) { // required, but no value
	if ($this->errorMessage === null) {
	$this->errorMessage = $this->prepareRequiredValidationFailureMessage();
	}
	return false;
	}
	if ($empty && ! $required && ! $continueIfEmpty) {
	return true;
	}
	if ($empty && $allowEmpty && ! $continueIfEmpty) {
	return true;
	}

laminas-inputfilter/src/Input.php

Lines 20 to 32 in 2e9a2f2

	/**
	* @deprecated 2.4.8 Add Laminas\Validator\NotEmpty validator to the ValidatorChain.
	*
	* @var bool
	*/
	protected $allowEmpty = false;
	/**
	* @deprecated 2.4.8 Add Laminas\Validator\NotEmpty validator to the ValidatorChain.
	*
	* @var bool
	*/
	protected $continueIfEmpty = false;

laminas-inputfilter/src/Input.php

Lines 46 to 51 in 2e9a2f2

	/**
	* @deprecated 2.4.8 Add Laminas\Validator\NotEmpty validator to the ValidatorChain.
	*
	* @var bool
	*/
	protected $notEmptyValidator = false;

An alternative solution or way was never provided and in its current state, it would not work. Therefore the deprecation was too early and all discussions and developments in this direction have never been completed or are very old.

See:

• Feature/required validator #10
• [bc\break] Remove deprecated and validators auto injections #7
• Deprecated properties in docs #34

As long as we do not have an alternative solution, the current deprecation messages are confusing.

[Ocramius]

Fine by me. Need another opinion from who introduced this deprecation

[gsteel]

I agree with the decision to un-deprecate this stuff. That said, I can see why it was deprecated as the "is it empty/required" dance is convoluted to say the least and the magic of auto injecting the NotEmpty validator is questionable.

IMO it's worth raising an issue that it all needs sorting out for the next major.

Does removing the deprecations alter the baseline?

[internalsystemerror]

No objections here. When/if a solution is found, is there a chance these deprecations would be readded as they are?

[Ocramius]

Ok, let's just re-generate the baseline, and then this can be merged.

Can't do myself: don't have docker on this PC today :D

[Ocramius]

Merging as-is here: can't re-generate baseline ATM, but it's a minor issue.

[Ocramius]

Thanks @froschdesign!