Skip to content
This repository has been archived by the owner on Dec 5, 2024. It is now read-only.

Adding details about the second parameter for Laminas\Log\Formatter\Simple, the DateTime object format #42

Merged
merged 2 commits into from
Aug 15, 2022

Conversation

galvao
Copy link
Contributor

@galvao galvao commented Aug 15, 2022

Q A
Documentation yes
Bugfix no
BC Break no
New Feature no
RFC no
QA no

Description

Adding details about the second parameter for Laminas\Log\Formatter\Simple, the DateTime object format.

galvao added 2 commits August 14, 2022 21:30
Signed-off-by: Er Galvão Abbott <galvao@galvao.eti.br>
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but this sort of information should really live in docblocks, and not in .md 🤔

@Ocramius Ocramius self-assigned this Aug 15, 2022
@Ocramius Ocramius added this to the 2.16.0 milestone Aug 15, 2022
@Ocramius Ocramius merged commit 105e210 into laminas:2.16.x Aug 15, 2022
@Ocramius
Copy link
Member

Thanks @galvao!

@Ocramius Ocramius changed the title Adding details about the second parameter for Laminas\Log\Formatter\Simple, the DateTime object format Adding details about the second parameter for Laminas\Log\Formatter\Simple, the DateTime object format Aug 15, 2022
@galvao
Copy link
Contributor Author

galvao commented Aug 15, 2022

Thanks @galvao!

You're very welcome! Sorry that I've missed the signing off in the first commit, but please go ahead without it, you have my permission, authorization or whatever! lol

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants