-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused variable #212
base: 2.18.x
Are you sure you want to change the base?
Conversation
Signed-off-by: Renovate Bot <bot@renovateapp.com>
Signed-off-by: Menno Holtkamp <holtkamp@users.noreply.github.com>
@holtkamp More information on this topic can be found in contributing guidelines:
|
What do you mean with: That $body variable is set twice. The first time is not needed. Additionally, the example is incorrect, it is missing this part which sets the content type of the "alternative" multipart part: https://github.com/laminas/laminas-mail/blob/2.19.x/test/MessageTest.php#L812-L814 Does this require a separate issue? |
FYI: changed target branch from |
Correct. I have only added the link as a reference. |
A rebase is needed. |
No, add it to this pull request as a separate commit. |
Signed-off-by: Menno Holtkamp <holtkamp@users.noreply.github.com>
Tried to rebase on Could be my lack of GIT skills, I used this as reference https://stackoverflow.com/questions/7929369/how-to-rebase-local-branch-onto-remote-master Feel free to edit my PR if applicable. (Squashing commits into a single commit is also something I still struggle with and that you will probably request me to do...) |
Signed-off-by: Menno Holtkamp <holtkamp@users.noreply.github.com>
Signed-off-by: Menno Holtkamp holtkamp@users.noreply.github.com