-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 8.1 support #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check CI failures too
CI failures are caused by wrong type hints in another libraries (laminas-db), different dependencies (CI test on PHP 7.3 fails due to psr/container needs PHP 7.4, ...) or wrong return type of Mock. Could you please check CI failures? There is probably nothing to fix. |
I created another pull request laminas/laminas-db#236. This will fix psalm failure because of wrong type in |
A |
@MatyCZ
And the Psalm error:
Thanks in advance! 👍 |
@froschdesign I am unable to fix psalm error: |
Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Upstream library has an incorrect annotation, which means the correctly marked one here is being incorrectly flagged as invalid. Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
@MatyCZ I pushed an update to the Psalm baseline to ignore that error; it's a problem with the upstream laminas-db library, so we can ignore it for now. However... we cannot accept this patch without signoff. You can add it to your existing commits by following the directions in our contributor document. Once you've done that, ping me, and I'll merge. |
Signed-off-by: Matej Szendi <matej.szendi@bcom.cz>
Signed-off-by: Matej Szendi <matej.szendi@bcom.cz>
Signed-off-by: Matej Szendi <matej.szendi@bcom.cz>
Signed-off-by: Matej Szendi <matej.szendi@bcom.cz>
Signed-off-by: Matej Szendi <matej.szendi@bcom.cz>
Signed-off-by: Matej Szendi <matej.szendi@bcom.cz>
Signed-off-by: Matej Szendi <matej.szendi@bcom.cz>
Signed-off-by: Matej Szendi <matej.szendi@bcom.cz>
Signed-off-by: Matej Szendi <matej.szendi@bcom.cz>
@weierophinney ping |
Signed-off-by: Matej Szendi <matej.szendi@bcom.cz>
Signed-off-by: Matej Szendi <matej.szendi@bcom.cz>
Signed-off-by: Matej Szendi <matej.szendi@bcom.cz>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @MatyCZ!
Description
Initial PHP 8.1 support.
Fixes #8