Support and require laminas-servicemanager v4.0
#25
Conversation
boesing
force-pushed
the
feature/servicemanager-4.0
branch
from
a74f4c8 to
6fb97f7
Compare
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
boesing
force-pushed
the
feature/servicemanager-4.0
branch
from
6fb97f7 to
db5be2f
Compare
| @@ -31,19 +31,18 @@ | |||
| } | |||
| }, | |||
| "require": { | |||
| "php": "~8.0.0 || ~8.1.0 || ~8.2.0", | |||
| "php": "~8.1.0 || ~8.2.0", | |||
There was a problem hiding this comment.
laminas-servicemanager dropped support for PHP 8.0 and thus we can drop it here as well.
| "laminas/laminas-json": "^3.1", | ||
| "laminas/laminas-servicemanager": "^4.0.0-rc2", |
There was a problem hiding this comment.
title says "add support", but implementation adds it as a requirement (wasn't one before, BTW).
Not sure what the right direction is here 🤔
There was a problem hiding this comment.
AFAIR we decided on stating explicit requirements in components to avoid surprises in upstream projects.
The AdapterPluginManager and the Serializer abstract class are totally depending on the AdapterPluginManager. So the only things which are not servicemanager related are the concrete implementations.
Not sure if we should extract the plugin manager specific code to a satellite instead but having 60+% of this component being dangling until composer requirements are fulfilled feels weird to me.
boesing
changed the title
laminas-servicemanager v4.0laminas-servicemanager v4.0
Description
This provides support for
laminas-servicemanagerv4.0