Add parameter and return types to Queue, Stack and List types #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ypes to match inherited types Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
froschdesign
requested changes
Sep 13, 2023
Co-authored-by: Frank Brückner <info@froschdesignstudio.de> Signed-off-by: George Steel <george@netglue.uk>
…guide Signed-off-by: George Steel <george@net-glue.co.uk>
froschdesign
approved these changes
Sep 13, 2023
Ocramius
reviewed
Sep 13, 2023
gsteel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds return/property/parameter types to a subset of the iterable types in Stdlib.
I've focussed on queues/stacks here to keep the patch small and easier to review. The intention is to work through other areas of the codebase and add type hints where appropriate in other patches, and update the migration guide with each patch.
This also fixes a bug in
SplPriorityQueuewhere a serialisation round trip would cause unexpected insertion order due to the state of$this->serialnot being updated during un-serialize.