Stricter typehints matching doc block hints #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test failures are indicating that some of these changes are in fact BC breaks; suggest I revert the changes that cause the tests to fail and we decide if they are wanted to go into a 4.0.x release at some point? |
…espace Signed-off-by: Carnage <t.carnage@gmail.com>
Signed-off-by: Carnage <t.carnage@gmail.com>
Signed-off-by: Carnage <t.carnage@gmail.com>
carnage
force-pushed
the
add-typehints
branch
from
01b6d09 to
389ac62
Compare
carnage
force-pushed
the
add-typehints
branch
from
389ac62 to
3cfe0c5
Compare
Signed-off-by: Carnage <t.carnage@gmail.com>
carnage
force-pushed
the
add-typehints
branch
from
3cfe0c5 to
f05287c
Compare
|
Have reverted the changes to the files which failed tests, rebased onto latest branch and retargeted against 3.7.x Should be ready to go now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar PR to: https://github.com/laminas/laminas-escaper/pull/23/files I started with the string wrapper namespace as an issue was raised against it.
Progressively adding more classes to this PR as time permitsI've added typehints to every class where it seems sensible to do so, there are some which inherit/implement built-ins which don't declare the type hint and so opens up a bit of an issue to then add them, you may wish to merge some parts and not others so splitting allows for easier cherry-picking.Only typehints which don't break bc have been added; eg ones which PHP will silently cast to when strict types = 0; notably callable type hints have not been added and some instances of iterable have been skipped where the previous behaviour was to throw an exception if it wasn't an iterable.