Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use PHP 8.1 syntax #89

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

samsonasik
Copy link
Member

Q A
QA yes

Description

Since composer.json require php 8.1, php 8.1 syntax can be applied.

Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
@samsonasik samsonasik added this to the 4.11.0 milestone Nov 3, 2024
@samsonasik
Copy link
Member Author

Ready for review 👍

@samsonasik samsonasik added the QA Quality assurance tasks such as static analysis improvements label Nov 18, 2024
@samsonasik samsonasik requested a review from gsteel November 22, 2024 16:06
Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @samsonasik

@gsteel gsteel self-assigned this Nov 22, 2024
@gsteel gsteel merged commit 1eb7393 into laminas:4.11.x Nov 22, 2024
11 checks passed
@samsonasik samsonasik deleted the update-to-use-php81-syntaxes branch November 22, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement QA Quality assurance tasks such as static analysis improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants