Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor file Count validator #356

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented Jul 11, 2024

Q A
Documentation yes
BC Break yes
QA yes

Description

  • Removes compat with legacy Laminas\File\Transfer api
  • Removes all option setters and getters
  • Accept only an options array to the constructor

- Removes compat with legacy `Laminas\File\Transfer` api
- Removes all option setters and getters
- Accept only an options array to the constructor

Signed-off-by: George Steel <george@net-glue.co.uk>
Copy link
Member

@froschdesign froschdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@gsteel gsteel self-assigned this Jul 11, 2024
@gsteel gsteel merged commit 3320ab8 into laminas:3.0.x Jul 11, 2024
14 of 15 checks passed
@gsteel gsteel deleted the v3/refactor-file-count branch July 11, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File/Count validator does not work
2 participants