Rewrite autoloader so we have all rules defined in separate class #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The class with defined rules now is reusable and we can use it also on rewriting the libraries We need to think what we can do with functions, and somehow I think it will be better to create these alias in repositories where we have defined functions. We would need define list of all possible function defined in libraries and then just call new function using `call_user_func_array` and `func_get_args`.
We should handle it separetely on rewriting packages
weierophinney
requested changes
Mar 28, 2019
michalbundyra
commented
Mar 28, 2019
We are using namespace segments instead of looping of the whole array of the namespaces to rewrite. Because of that we are able to quit after 1 or 2 checks, otherwise - if we use normal loop - in the worst case scenario - we need to have 12 checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class with defined rules now is reusable and we can use it also on rewriting the libraries
We need to think what we can do with functions, and somehow I think it will be better to create these alias in repositories where we have defined functions.We would need define list of all possible function defined in libraries and then just call new function usingcall_user_func_arrayandfunc_get_args.UPDATE: As discussed, we will try to handle functions separately on rewriting packages, as these are only in the following pacakges: