Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for Renovate with reusable workflows #92

Merged
merged 8 commits into from
Feb 22, 2022
Merged

Prepare for Renovate with reusable workflows #92

merged 8 commits into from
Feb 22, 2022

Conversation

ghostwriter
Copy link
Contributor

Q A
QA yes

Description

Adding Renovate to Laminas, Mezzio repositories. https://gist.github.com/weierophinney/49ca8ae2b916d898dd3d4162b26ff41b

  • Configure minimum supported PHP version
  • Update composer dependencies
  • Update to reusable Continuous Integration workflow
  • Update to reusable Automatic Releases workflow

@ghostwriter
Update to reusable continuous-integration workflow
b239aba 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter
Update to reusable automatic-releases workflow
fca1146 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter
Configure minimum supported PHP version
c3264aa 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@Ocramius Ocramius added this to the 1.5.0 milestone Feb 21, 2022
Ocramius
Ocramius requested changes Feb 21, 2022
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires rolling back to a much smaller composer.lock change (just hash change)

@ghostwriter
Drop support for PHP 7.3
5a31f2d 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter
Update psalm.xml.dist
9f8b50b 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Ocramius
Ocramius requested changes Feb 22, 2022
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minimal adjustments needed, but I think we're almost there :D

@ghostwriter
Update Autoloader.php
cf89f08 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter
Update psalm.xml.dist
fd24145 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter ghostwriter requested a review from Ocramius February 22, 2022 22:12
@ghostwriter
Update psalm-baseline.xml
d207d1f 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Ocramius
Ocramius approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ghostwriter !

@Ocramius Ocramius self-assigned this Feb 22, 2022
@Ocramius Ocramius merged commit 7f04939 into laminas:1.5.x Feb 22, 2022
@ghostwriter ghostwriter deleted the feature/renovate branch February 22, 2022 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
Enhancement
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ghostwriter @Ocramius