🐛 Fix ZeroDivisionError in inspect (#75)

* 🐛 Fix zero division eror in inspect * 👷 Run 3.10 * 🧪 Add tests
laminlabs · Mar 21, 2024 · 50ff369 · 50ff369
1 parent 368016a
commit 50ff369
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 2 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -12,7 +12,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: ["3.9"]
+        python-version: ["3.10"]
 
     steps:
       - uses: actions/checkout@v3
@@ -34,6 +34,6 @@ jobs:
       - run: nox -s lint
       - run: nox -s build
       - uses: codecov/codecov-action@v2
-        if: matrix.python-version == '3.9'
+        if: matrix.python-version == '3.10'
         with:
           token: ${{ secrets.CODECOV_TOKEN }}
diff --git a/lamin_utils/_inspect.py b/lamin_utils/_inspect.py
@@ -54,6 +54,15 @@ def _validate_stats(identifiers: Iterable, matches: "np.ndarray"):
     nonval = _unique_rm_empty(df_val.index[~df_val["__validated__"]]).tolist()
 
     n_unique = len(val) + len(nonval)
+    if n_unique == 0:
+        return InspectResult(
+            validated_df=df_val,
+            validated=val,
+            nonvalidated=nonval,
+            frac_validated=0,
+            n_empty=0,
+            n_unique=0,
+        )
     n_empty = df_val.shape[0] - n_unique
     frac_nonval = round(len(nonval) / n_unique * 100, 1)
     frac_val = 100 - frac_nonval

diff --git a/tests/test_inspect.py b/tests/test_inspect.py
@@ -129,6 +129,16 @@ def test_inspect_empty_dup_input(genes):
     assert result.non_validated == []
 
 
+def test_inspect_zero_identifiers():
+    result = inspect(
+        df=pd.DataFrame(),
+        identifiers=pd.Series([]),
+        field="symbol",
+    )
+    assert result.validated == []
+    assert result.non_validated == []
+
+
 def test_inspect_empty_df():
     import numpy as np
     import pandas as pd