♻️ Base connect_hub() off of edge function
#879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #879 +/- ##
==========================================
- Coverage 83.76% 83.51% -0.25%
==========================================
Files 43 43
Lines 3381 3355 -26
==========================================
- Hits 2832 2802 -30
- Misses 549 553 +4 ☔ View full report in Codecov by Sentry. |
Koncopd
commented
Oct 3, 2024
| @@ -56,6 +56,8 @@ def __init__( | |||
| schema: str | None = None, # comma-separated string of schema names | |||
| git_repo: str | None = None, # a git repo URL | |||
| is_on_hub: bool | None = None, # initialized from hub | |||
| api_url: str | None = None, | |||
| schema_id: UUID | None = None, | |||
There was a problem hiding this comment.
@falexwolf not sure. I have to add them here for saving the instance settings. But i am not sure if they should be here even as just private variables.
falexwolf
changed the title
connect_hub() off of edge function
|
@Koncopd, can we merge this one? |
|
One more thing and i will merge. |
This was
linked to
issues
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.