🎨 Simplify InstanceNotEmpty UX #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zethson <lukas.heumos@posteo.net>
Signed-off-by: zethson <lukas.heumos@posteo.net>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #929 +/- ##
=======================================
Coverage 83.53% 83.53%
=======================================
Files 43 43
Lines 3444 3444
=======================================
Hits 2877 2877
Misses 567 567 ☔ View full report in Codecov by Sentry. |
Koncopd
reviewed
Jan 8, 2025
| @@ -865,7 +865,7 @@ def check_storage_is_empty( | |||
| ) | |||
| if n_diff > 0: | |||
| if raise_error: | |||
| raise InstanceNotEmpty(message) | |||
| raise InstanceNotEmpty(message) from None | |||
There was a problem hiding this comment.
If this works, we can adopt it in other places also where we use sys exits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #928
InstanceNotEmptyexception is raised