Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Check for more CI environments #931

Merged
merged 1 commit into from
Jan 10, 2025
Merged

✨ Check for more CI environments #931

merged 1 commit into from
Jan 10, 2025

Conversation

Zethson
Copy link
Member

@Zethson Zethson commented Jan 10, 2025

Fixes laminlabs/lamindb#1851

  • Now checking for more common CI environment variables to disable the NotebookNotSaved error from ln.finish()
  • Since we're using Github Actions we could now probably get rid of LAMIN_TESTING but one step at a time

Signed-off-by: Lukas Heumos <lukas.heumos@posteo.net>
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.53%. Comparing base (130926e) to head (dedd847).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #931      +/-   ##
==========================================
+ Coverage   83.51%   83.53%   +0.01%     
==========================================
  Files          43       43              
  Lines        3446     3449       +3     
==========================================
+ Hits         2878     2881       +3     
  Misses        568      568              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@github-actions github-actions bot temporarily deployed to pull request January 10, 2025 10:16 Inactive
@Zethson Zethson requested a review from Koncopd January 10, 2025 10:23
@Zethson Zethson marked this pull request as ready for review January 10, 2025 10:23
@Zethson Zethson merged commit 9bbddb9 into main Jan 10, 2025
13 checks passed
@Zethson Zethson deleted the feature/ci_finish branch January 10, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

finish() support for CI environments
2 participants