Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚚 Deprecate the --schema argument of lamin init in favor of --modules #938

Merged
merged 14 commits into from
Jan 11, 2025

Conversation

falexwolf
Copy link
Member

No description provided.

@falexwolf falexwolf changed the title 🚚 Deprecated the --schema argument in favor of --modules 🚚 Deprecated the --schema argument of lamin init in favor of --modules Jan 11, 2025
@falexwolf falexwolf changed the title 🚚 Deprecated the --schema argument of lamin init in favor of --modules 🚚 Deprecate the --schema argument of lamin init in favor of --modules Jan 11, 2025
@falexwolf falexwolf merged commit 9899f5c into main Jan 11, 2025
10 checks passed
@falexwolf falexwolf deleted the deprecateschema branch January 11, 2025 23:25
Copy link

codecov bot commented Jan 11, 2025

Codecov Report

Attention: Patch coverage is 82.75862% with 5 lines in your changes missing coverage. Please review.

Project coverage is 83.74%. Comparing base (e977f67) to head (569db96).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
lamindb_setup/_exportdb.py 0.00% 2 Missing ⚠️
lamindb_setup/_importdb.py 0.00% 2 Missing ⚠️
lamindb_setup/core/_settings_instance.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #938      +/-   ##
==========================================
+ Coverage   83.58%   83.74%   +0.15%     
==========================================
  Files          43       43              
  Lines        3449     3458       +9     
==========================================
+ Hits         2883     2896      +13     
+ Misses        566      562       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@github-actions github-actions bot temporarily deployed to pull request January 11, 2025 23:29 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant