Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 Remove thread error suppression on Windows #944

Merged
merged 8 commits into from
Jan 16, 2025
Merged

🔥 Remove thread error suppression on Windows #944

merged 8 commits into from
Jan 16, 2025

Conversation

Koncopd
Copy link
Member

@Koncopd Koncopd commented Jan 16, 2025

We set auto_refresh_token=False for supabase anyways so it is redundant.

Closes #933

Context #37

Copy link

github-actions bot commented Jan 16, 2025

@github-actions github-actions bot temporarily deployed to pull request January 16, 2025 12:17 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 16, 2025 12:35 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 16, 2025 12:48 Inactive
@Koncopd Koncopd merged commit 96a8b93 into main Jan 16, 2025
11 checks passed
@Koncopd Koncopd deleted the ref_err branch January 16, 2025 12:50
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.98%. Comparing base (d1969b1) to head (e9968cd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #944      +/-   ##
==========================================
+ Coverage   83.75%   83.98%   +0.22%     
==========================================
  Files          43       43              
  Lines        3472     3459      -13     
==========================================
- Hits         2908     2905       -3     
+ Misses        564      554      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@falexwolf
Copy link
Member

Nice clean up! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is suppressing the threading error on Windows still needed.
2 participants